Closed Bug 895253 Opened 7 years ago Closed 7 years ago

Disable crash reporter when building android fennec on osx

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

We shouldn't rely on individual developers setting --disable-crashreporter on their build. The build system should do it itself.
Any place that sets --disable-crashreporter after including mozconfig.common will properly use --disable-crashreporter.
Attachment #777591 - Flags: review?(ted)
Comment on attachment 777591 [details] [diff] [review]
Disable crash reporter when cross building across different OSes (e.g. OSX android builds)

Review of attachment 777591 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mozconfig.common
@@ +11,5 @@
>  # of this file.
>  
>  mk_add_options AUTOCLOBBER=1
> +
> +ac_add_options --enable-crashreporter

I don't understand why you need this.
Attachment #777591 - Flags: review?(ted)
Comment on attachment 777591 [details] [diff] [review]
Disable crash reporter when cross building across different OSes (e.g. OSX android builds)

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> > +ac_add_options --enable-crashreporter
> 
> I don't understand why you need this.

To avoid having the crash reporter unknowingly disabled for some reason.
Attachment #777591 - Flags: review?(ted)
Comment on attachment 777591 [details] [diff] [review]
Disable crash reporter when cross building across different OSes (e.g. OSX android builds)

Review of attachment 777591 [details] [diff] [review]:
-----------------------------------------------------------------

I still don't really understand. Are you worried that we'll accidentally start building in some cross-compile configuration which disables crashreporting?

I'm not morally opposed to it, it just seems wrong to have to specify something that's actually a default.
Attachment #777591 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> I still don't really understand. Are you worried that we'll accidentally
> start building in some cross-compile configuration which disables
> crashreporting?

Or someone rearranges configure.in and adds a bug, or whatever.
https://hg.mozilla.org/mozilla-central/rev/f710d274e853
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.