Closed Bug 895426 Opened 11 years ago Closed 11 years ago

Intermittent browser_dbg_break-on-dom-event.js | Test timed out and sometimes browser_dbg_event-listeners.js | leaked until shutdown [nsGlobalWindow #8888 http://example.com/browser/browser/devtools/debugger/test/test-event-listeners.html]

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Platform:
x86
macOS
Type:
defect

Tracking

(firefox24 unaffected, firefox25 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 25
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 --- fixed

People

(Reporter: past, Assigned: past)

References

Details

(Keywords: intermittent-failure, memory-leak)

Attachments

(2 files, 1 obsolete file)

Add paused listeners before resumptions to avoid an intermittent test failure
2.29 KB, patch
Details | Diff | Splinter Review
Another attempt to fix an intermittent Mac-only test failure
2.68 KB, patch
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=25431285&tree=Fx-Team Rev4 MacOSX Snow Leopard 10.6 fx-team opt test mochitest-browser-chrome on 2013-07-18 05:30:21 PDT for push c3f39498c164 slave: talos-r4-snow-082 05:32:18 ERROR - Return code: 1 05:32:19 ERROR - Return code: 1 05:45:28 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_break-on-dom-event.js | Test timed out
Summary: Intermittent browser_dbg_break-on-dom-event.js | Test timed out → Intermittent browser_dbg_break-on-dom-event.js | Test timed out and sometimes browser_dbg_event-listeners.js | leaked until shutdown [nsGlobalWindow #8888 http://example.com/browser/browser/devtools/debugger/test/test-event-listeners.html]
My theory is that the paused event fires before the listener is added, so this should hopefully fix this failure: https://hg.mozilla.org/integration/fx-team/rev/a4e8ace8a4a9
https://hg.mozilla.org/mozilla-central/rev/a4e8ace8a4a9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
There were a few more cases of the same pattern that I missed in the previous fix. This seems to never fail locally.
https://hg.mozilla.org/integration/fx-team/rev/ae5335706710
Status: REOPENED → ASSIGNED
Whiteboard: [fixed-in-fx-team]
(In reply to Tim Taubert [:ttaubert] from comment #14) > https://hg.mozilla.org/mozilla-central/rev/a4e8ace8a4a9 Why in the world was this merged to m-c with it failing nearly 100% of the time on OSX?
Forgot that a modified file was shared with another test. This did seem to improve things on try.
Attachment #779380 - Attachment is obsolete: true
It's less common in fx-team with the latest version, but I think I got it figured out this time: https://hg.mozilla.org/integration/fx-team/rev/d9db157a64ca
https://hg.mozilla.org/mozilla-central/rev/ae5335706710 https://hg.mozilla.org/mozilla-central/rev/a32cff34271c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Occurring on m-c tip, which has the second patch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to TinderboxPushlog Robot from comment #170) > RyanVM > https://tbpl.mozilla.org/php/getParsedLog.php?id=25623678&tree=Fx-Team > Rev4 MacOSX Lion 10.7 fx-team opt test mochitest-browser-chrome on > 2013-07-23 12:17:19 > revision: 73f2e30e0154 > slave: talos-r4-lion-038 > > 12:19:41 ERROR - Return code: 1 > 12:19:42 ERROR - Return code: 1 > 12:33:15 WARNING - TEST-UNEXPECTED-FAIL | > chrome://mochitests/content/browser/browser/devtools/debugger/test/ > browser_dbg_break-on-dom-event.js | Test timed out This was from fx-team tip. Can we just disable this test already?
https://hg.mozilla.org/mozilla-central/rev/6f21c0bcd747
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Blocks: 898199
The browser_dbg_event-listeners.js leaks are still happening even with browser_dbg_break-on-dom-event.js disabled. Filed bug 898199.
Keywords: mlk
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: