Closed Bug 898199 Opened 11 years ago Closed 11 years ago

Intermittent browser_dbg_event-listeners.js | leaked until shutdown [nsGlobalWindow #8888 http://example.com/browser/browser/devtools/debugger/test/test-event-listeners.html]

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Platform:
x86_64
macOS
Type:
defect

Tracking

(firefox27 unaffected, firefox28 fixed, firefox-esr24 unaffected, b2g-v1.2 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 28
Tracking Flags:
Tracking Status
firefox27 --- unaffected
firefox28 --- fixed
firefox-esr24 --- unaffected
b2g-v1.2 --- unaffected

People

(Reporter: mbrubeck, Assigned: vporof)

References

Details

(Keywords: intermittent-failure, memory-leak)

Attachments

(1 file, 1 obsolete file)

reenable.patch
2.01 KB, patch
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #895426 +++

https://tbpl.mozilla.org/php/getParsedLog.php?id=25740313&tree=Mozilla-Inbound

Rev4 MacOSX Lion 10.7 mozilla-inbound opt test mochitest-browser-chrome on 2013-07-25 15:34:19 PDT for push 300f5b7d72e1

slave: talos-r4-lion-042

16:09:25     INFO -  INFO TEST-END | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/xpinstall/browser_whitelist6.js | finished in 324ms
16:09:25     INFO -  TEST-INFO | checking window state
16:09:33  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_event-listeners.js | leaked until shutdown [nsGlobalWindow #9102 http://example.com/browser/browser/devtools/debugger/test/test-event-listeners.html]
16:09:33  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_event-listeners.js | leaked until shutdown [nsGlobalWindow #9104 http://example.com/browser/browser/devtools/debugger/test/test-event-listeners.html]
16:09:33     INFO -  INFO TEST-START | Shutdown
Attached patch dbg-disable-event.patch (obsolete) — — Splinter Review 
Just like bug 895426, this fails only on OS X. Bug 876277 don't seem to affect this too much, although it took a few hundred reruns on try to get this leak. What do you think Panos, should we disable it on Darwin?
Attachment #803593 - Flags: review?(past)
Comment on attachment 803593 [details] [diff] [review]
dbg-disable-event.patch

Review of attachment 803593 [details] [diff] [review]:
-----------------------------------------------------------------

OK, I guess.
Attachment #803593 - Flags: review?(past) → review+
https://hg.mozilla.org/integration/fx-team/rev/bc767637c932
Assignee: nobody → vporof
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bc767637c932
Whiteboard: [fixed-in-fx-team] → [test disabled on OSX][leave open]
Assignee: vporof → nobody
Attachment #803593 - Attachment is obsolete: true
Blocks: 942102
This could probably be reenabled now, in light of bug 941787 fixing these sorts of problems.
Flags: needinfo?(vporof)
Yes, I think it's definitely worth a shot.
Flags: needinfo?(vporof)
Attached patch reenable.patch — — Splinter Review 

    
    

    
  
Looks like this worked!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [test disabled on OSX][leave open]
Assignee: nobody → vporof
Target Milestone: --- → Firefox 28

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: