Closed Bug 895572 Opened 6 years ago Closed 6 years ago

modules/libmar tests cannot be run concurrently

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: mihneadb, Assigned: mihneadb)

References

Details

Attachments

(1 file, 2 obsolete files)

They are using the shared tests folder.
Blocks: 887064
Attached patch use a tmpdir (obsolete) — Splinter Review
Using a tmpdir instead of the shared tests dir.

I'm creating it in the global namespace because we need a handle to the tempdir
inside two different functions and if we were to call the function (do_get_tempdir)
twice we'd end up with two temp dirs.
Attachment #778010 - Flags: review?(robert.bugzilla)
Assignee: nobody → mihneadb
Attachment #778010 - Flags: review?(robert.bugzilla) → review?(netzen)
Comment on attachment 778010 [details] [diff] [review]
use a tmpdir

Review of attachment 778010 [details] [diff] [review]:
-----------------------------------------------------------------

I think you want to do similar changes inside test_sign_verify.js

::: modules/libmar/tests/unit/test_create.js
@@ +60,2 @@
>        let differentFile = do_get_file("data/1_byte_mar.mar");
>        let outMARDir = do_get_file(".");

I think you want to use tempDir.clone() here
Attachment #778010 - Flags: review?(netzen)
Attached patch use the sandboxed tempDir (obsolete) — Splinter Review
Thanks, missed those!
Attachment #779040 - Flags: review?(netzen)
Attachment #778010 - Attachment is obsolete: true
Comment on attachment 779040 [details] [diff] [review]
use the sandboxed tempDir

Review of attachment 779040 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Nit: You need to update the reviewer on the patch.
Attachment #779040 - Flags: review?(netzen) → review+
Updated reviewer.
Attachment #779040 - Attachment is obsolete: true
Comment on attachment 779235 [details] [diff] [review]
use the sandboxed tempDir

keeping r+
Attachment #779235 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e287a3a5088e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.