895572 - modules/libmar tests cannot be run concurrently

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mihnea Dobrescu-Balaur (:mihneadb)]

They are using the shared tests folder.

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use a tmpdir

Using a tmpdir instead of the shared tests dir.

I'm creating it in the global namespace because we need a handle to the tempdir
inside two different functions and if we were to call the function (do_get_tempdir)
twice we'd end up with two temp dirs.

Comment 2

[Mihnea Dobrescu-Balaur (:mihneadb)]

https://tbpl.mozilla.org/?tree=Try&rev=6cf5ae53b262

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 778010 [details] [diff] [review]
use a tmpdir

Review of attachment 778010 [details] [diff] [review]:
-----------------------------------------------------------------

I think you want to do similar changes inside test_sign_verify.js

::: modules/libmar/tests/unit/test_create.js
@@ +60,2 @@
>        let differentFile = do_get_file("data/1_byte_mar.mar");
>        let outMARDir = do_get_file(".");

I think you want to use tempDir.clone() here

Comment 4

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use the sandboxed tempDir

Thanks, missed those!

Comment 5

[Mihnea Dobrescu-Balaur (:mihneadb)]

New try run - https://tbpl.mozilla.org/?tree=Try&rev=af74497c3f77

Comment 6

[Brian R. Bondy [:bbondy]]

Comment on attachment 779040 [details] [diff] [review]
use the sandboxed tempDir

Review of attachment 779040 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Nit: You need to update the reviewer on the patch.

Comment 7

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: use the sandboxed tempDir

Updated reviewer.

Comment 8

[Mihnea Dobrescu-Balaur (:mihneadb)]

Comment on attachment 779235 [details] [diff] [review]
use the sandboxed tempDir

keeping r+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e287a3a5088e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e287a3a5088e