Closed Bug 895669 Opened 11 years ago Closed 11 years ago

Change - override about:addons to display a metro custom page


(Firefox for Metro Graveyard :: Browser, defect, P1)

Windows 8


(Not tracked)

Firefox 25


(Reporter: ally, Assigned: ally)



(Whiteboard: feature=change c=tbd u=tbd p=5)


(4 files, 4 obsolete files)

Since we are not allowing addons in v1, we should disable the ability to access about:addons, as the current about:addons looks very functional and gives no indication that metro addons are not supported.
Summary: disable access to about:addons → Change - Disable access to about:addons
Whiteboard: feature=change c=tbd u=tbd p=0
Priority: -- → P1
Assignee: nobody → ally
Attached patch debugging (obsolete) — Splinter Review
Blocks: metrov1it11
No longer blocks: metrov1defect&change
QA Contact: jbecerra
Whiteboard: feature=change c=tbd u=tbd p=0 → feature=change c=tbd u=tbd p=5
Summary: Change - Disable access to about:addons → Change - override about:addons to disable a metro custom page
as discussed on irc with mfinkle & yuan, the plan is now to override extensions.xul to display a custom page with a cute image and short, localizable message indicated that addons are not currently supported.
Blocks: metrov1it12
No longer blocks: metrov1it11
Attached patch wip, works, but is u-g-l-y (obsolete) — Splinter Review
it seems like it can't find the css file.
also the new files have icky windows line endings.
Summary: Change - override about:addons to disable a metro custom page → Change - override about:addons to display a metro custom page
Attached patch metroaboutaddonsSplinter Review
Attachment #780067 - Attachment is obsolete: true
Attachment #783390 - Attachment is obsolete: true
Attachment #784542 - Flags: review?(sfoster)
Attached image Screenshot
Comment on attachment 784542 [details] [diff] [review]

Review of attachment 784542 [details] [diff] [review]:

Just this thought for snapped-view (which I know we already determined was low priority)

::: browser/metro/theme/aboutAddons.css
@@ +2,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at */
> +
> +html, body {
> +  height: 100%;

If you add: 
padding: 0; 
margin: 0; you'll get edge-edge color which I think you want.

@@ +28,5 @@
> +  text-align: left;
> +  word-wrap: normal;
> +}
> +
> +#fox {  

nit: trailing whitespace

@@ +36,5 @@
> +  background-position: bottom center;
> +  background-repeat: no-repeat, repeat-x;
> +  background-color: rgb(230, 230, 230); /*color hand sampled from image*/
> +
> +}

You add something simple like the following to get something quite usable for snapped-view: 

/* Snapped-view variation */
@media (max-width: 330px) {

  #floatingTextBox {
    top: 20%;
    left: 5%;
    width: 90%;

Attachment #784542 - Flags: review?(sfoster) → review+
Attached patch r+ with nits & media query (obsolete) — Splinter Review
my thinkpad is rendering large black bars for snapped view still, so I can't actually test the snapped part of that patch yet. Builds are running and it'll be a race to verify
thanks Rodrigo!
Attachment #785190 - Attachment is obsolete: true
wish bugzilla had a good way to preview the text of the patch so you could doublecheck that the file contains the right version.
Attachment #785207 - Attachment is obsolete: true
Metro team is now checking in code on fx-team not inbound, and fx-team has been closed for most of today.
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: feature=change c=tbd u=tbd p=5 → feature=change c=tbd u=tbd p=5[fixed-in-fx-team]
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: feature=change c=tbd u=tbd p=5[fixed-in-fx-team] → feature=change c=tbd u=tbd p=5
Target Milestone: --- → Firefox 25
Blocks: 901487
Attached image screenshot.png
Please see the attached screenshot. This is how it looks for me the about:addons page, on a Win 8 64bit machine, using the latest Nightly, build ID: 20130819030205, tested for iteration #12.

Is this the expected?
Flags: needinfo?
Yes, this is the expected content.
Flags: needinfo?
Thanks! :)

Marking this VERIFIED, based on comment 13 and comment 14.
Depends on: 930367
Went through the following "Change" for iteration #16 and found some issues. Used the following build:

- Went through the suggestions throughout the thread and ensured everything described was implemented and working
- Went to "about:addons" and ensured that the correct image appeared
- Ensured that "Nightly Start Page" redirects the user to the awesome screen without any issues
- Viewed "about:addons" in full, filled and snap view and ensured that the image is displayed correctly
- Went through the above test cases in both Windows 8 and Windows 8.1


Ran into a small issue when going through the change in Windows 8.1. When you view the page in the different views, the text will but cut off at times. In Windows 8, it auto corrects and appears correctly but in 8.1 it stays cut off. Created Bug 930367
You need to log in before you can comment on or make changes to this bug.