Closed Bug 895819 Opened 11 years ago Closed 11 years ago

[fig] about:home should show the "Visited" tab when triggered from a tap on the URL bar

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

All
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: lucasr, Assigned: capella)

References

Details

(Whiteboard: [fixed-fig], abouthome-hackathon)

Attachments

(1 file, 1 obsolete file)

Right now, we always show the Bookmarks tab by default when showing about:home. This bug depends on the patch in bug 893529.
Summary: about:home should show the "Visited" when triggered from a tap on the URL bar → about:home should show the "Visited" tab when triggered from a tap on the URL bar
Attached patch bug895819 Entire Patch (obsolete) — Splinter Review
This can build on bug 893529 something like this... Still defaults to the Bookmarks page (Initial FF startup, etc)... on URL click switches to VISITED page
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attachment #778429 - Flags: review?(lucasr.at.mozilla)
Whiteboard: abouthome-hackathon
Comment on attachment 778429 [details] [diff] [review]
bug895819 Entire Patch

Review of attachment 778429 [details] [diff] [review]:
-----------------------------------------------------------------

I like the direction. Not sure the method renaming is necessary in the first place. I don't feel strongly about it though. If you still feel the new method names are worth it, please rename them in a separate patch.

::: mobile/android/base/BrowserApp.java
@@ +1304,5 @@
>      }
>  
> +    public boolean enterEditingMode(EditingTarget target, String url) {
> +        return enterEditingMode(target, url, HomePager.Page.BOOKMARKS);
> +    }

Add a third variant that takes target and page?

@@ +1372,3 @@
>      }
>  
> +    private void showHomePagerWithoutAnimation(HomePager.Page page) {

Rationale behind these method renames? In any case, refactorings like this should go on a separate patch.
Attachment #778429 - Flags: review?(lucasr.at.mozilla) → review-
There really wasn't a rational ... (meh) ... was a wild assed random thought
Attachment #778429 - Attachment is obsolete: true
Attachment #779312 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 779312 [details] [diff] [review]
bug895819 Entire Patch

Review of attachment 779312 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome.
Attachment #779312 - Flags: review?(lucasr.at.mozilla) → review+
Summary: about:home should show the "Visited" tab when triggered from a tap on the URL bar → [fig] about:home should show the "Visited" tab when triggered from a tap on the URL bar
Whiteboard: abouthome-hackathon → fixed-fig, abouthome-hackathon
please put whiteboard tags in square brackets for reporting.
Whiteboard: fixed-fig, abouthome-hackathon → [fixed-fig], abouthome-hackathon
https://hg.mozilla.org/mozilla-central/rev/2c8f72dc409c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: