895836 - [Australis] Margin of the navigation bar is too much in the customization mode

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[kazukigot1]

Attachment: Screenshot of the problem

Steps to reproduce:
Enter customize mode

Result:
Padding increases at the top and bottom of the navigation bar

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: reduce margin of the navbar in customization mode

Also noticeable on OSX. Reducing the margin to 1px seems all that's needed.

Comment 2

[:Gijs (out for now; he/him)]

Comment on attachment 821000 [details] [diff] [review]
Patch v1: reduce margin of the navbar in customization mode

Review of attachment 821000 [details] [diff] [review]:
-----------------------------------------------------------------

If you fix this anyway, can you also improve that selector to not suck quite as much? E.g.

#nav-bar[customizing="true"] > #nav-bar-customization-target

(although I wonder why we need a different margin for customization mode at all?)

And is the horizontal margin actually wrong? I don't believe so - the menu button already hugs the side of the box pretty closely. Please don't change that margin.

(r=me with the above fixed)

Comment 3

[Mike de Boer [:mikedeboer]]

Pushed with preserved horizontal margins. I did not change the selector(s), because that opened up a can of worms. I file a follow-up to try and make these selectors more specific.

https://hg.mozilla.org/projects/ux/rev/0fd98e856b49

Comment 4

[:Gijs (out for now; he/him)]

https://hg.mozilla.org/mozilla-central/rev/0fd98e856b49