931108 - Dotted outline of navbar in customize mode is in the wrong place after bug 895836

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (out for now; he/him)]

I suspect that it was genuinely the padding that needed changing, not the margin.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: use outline-offset to ensure the nav-bar outline isn't adjacent to the border,

The margin was reduced by 2px, so to put the outline back in the original place I'd have to use offset: -2px, but unfortunately that makes the offset touch the back button. So I went with -1px, which at least makes it no longer touch the navbar's top border.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 826699 [details] [diff] [review]
use outline-offset to ensure the nav-bar outline isn't adjacent to the border,

Review of attachment 826699 [details] [diff] [review]:
-----------------------------------------------------------------

As per our discussion on IRC, Gijs also thinks this does not fix the issue and needs more time to investigate.

::: browser/themes/shared/customizableui/customizeMode.inc.css
@@ -15,5 @@
>    transition-timing-function: linear;
>  }
>  
>  #nav-bar[customizing] > #nav-bar-customization-target {
> -  margin: 1px 3px;

this re-introduces bug 895836.

Comment 3

[:Gijs (out for now; he/him)]

I looked at this some more, and I think we should probably fix bug 893661 first, otherwise the outcome here will just regress again. Unassigning for now.

Comment 4

[Matthew N. [:MattN]]

I don't see the outline at all in the nav-bar on OS X anymore.

Comment 5

[:Gijs (out for now; he/him)]

Matt, I think this looked OK after bug 963576 was done. If you agree, can you close as FIXED and set the right target milestone, assignee, and set the right tracking flags for 29 and 30? Thanks!

Comment 6

[Matthew N. [:MattN]]

Yeah, I set outline-offset in bug 963576 to address this (or at least from what I can tell without a screenshot in this bug). I forgot this bug existed.