Closed
Bug 896223
Opened 11 years ago
Closed 11 years ago
Remove the version 1 manifest from the mar creation scripts
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox29 fixed, firefox30 fixed)
RESOLVED
FIXED
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file)
23.84 KB,
patch
|
nthomas
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Since all users must update to Firefox 12 before they update to newer versions the version 1 update.manifest is no longer needed.
Assignee | ||
Comment 1•11 years ago
|
||
I would like to make these changes at the same time as bug 759469 so adding dependency
Depends on: 759469
Assignee | ||
Comment 2•11 years ago
|
||
Nick, not sure who would be best to review this so feel free to pass this review onto someone else.
Attachment #784053 -
Flags: review?(nthomas)
Comment 3•11 years ago
|
||
I'll take a closer look at this tomorrow, but eyeballs fine from a high level.
Comment 4•11 years ago
|
||
Sorry for the delay, I've been unwell and will get to this as soon as I can.
Assignee | ||
Comment 5•11 years ago
|
||
No problem Nick and I hope you feel better soon.
Comment 6•11 years ago
|
||
Comment on attachment 784053 [details] [diff] [review]
patch rev1
Review of attachment 784053 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #784053 -
Flags: review?(nthomas) → review+
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Assignee | ||
Comment 7•11 years ago
|
||
Pushed to mozilla-central
https://hg.mozilla.org/mozilla-central/rev/c6123402c5f6
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 784053 [details] [diff] [review]
patch rev1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): None
User impact if declined: Releng will need to perform additional work to create update mar files for additional cycles to update beta users to release bits.
Testing completed (on m-c, etc.): This has been on m-c for several days, I've manually verified thoroughly, tests in bug 759469
Risk to taking this patch (and alternatives if risky): Minimal
String or IDL/UUID changes made by this patch: None
Attachment #784053 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
status-firefox29:
--- → affected
Updated•11 years ago
|
Attachment #784053 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•11 years ago
|
||
Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/fe8c8f40fea6
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•