Closed
Bug 896292
Opened 11 years ago
Closed 11 years ago
Mark widget/gtk2/ as FAIL_ON_WARNINGS
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
591 bytes,
patch
|
gps
:
review+
karlt
:
review+
|
Details | Diff | Splinter Review |
The directory widget/gtk2/ is warning-free, with bug 896032's patch. (which just landed on inbound).
Filing this bug on marking it as FAIL_ON_WARNINGS.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #779000 -
Flags: review?(karlt)
Assignee | ||
Comment 2•11 years ago
|
||
[Requesting widget:gtk peer approval, as well as build-peer approval per recent dev.platform thread, since this is a Makefile change]
Comment 3•11 years ago
|
||
Comment on attachment 779000 [details] [diff] [review]
fix v1
I assume our -Wno-error=deprecated-declarations saves us from bug 843288 here.
Attachment #779000 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Indeed -- I should've mentioned that, sorry. That was added in bug 833405.
Depends on: 833405
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 779000 [details] [diff] [review]
fix v1
Bumping review to gps, since Ted's away.
Attachment #779000 -
Flags: review?(ted) → review?(gps)
Updated•11 years ago
|
Attachment #779000 -
Flags: review?(gps) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Flags: in-testsuite-
Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/74589e31436d for PGO-only build bustage.
https://tbpl.mozilla.org/php/getParsedLog.php?id=25694203&tree=Mozilla-Inbound
Assignee | ||
Comment 8•11 years ago
|
||
Darn. Looks like that warning is tracked in bug 581478. Hence, marking this as depending on bug 581478.
Depends on: 581478
Assignee | ||
Comment 9•11 years ago
|
||
Just pushed a fix for bug 581478, so we should be able to land this again.
I triggered a new Try run, to be sure this dir is still warning-free (since a few new files were added to widget/gtk2 in the last day or so): https://tbpl.mozilla.org/?tree=Try&rev=10ad043cb42e
Assignee | ||
Comment 10•11 years ago
|
||
Comment 11•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•