Closed Bug 896292 Opened 8 years ago Closed 8 years ago

Mark widget/gtk2/ as FAIL_ON_WARNINGS

Categories

(Core :: Widget: Gtk, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

The directory widget/gtk2/ is warning-free, with bug 896032's patch. (which just landed on inbound).

Filing this bug on marking it as FAIL_ON_WARNINGS.
Attached patch fix v1Splinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #779000 - Flags: review?(ted)
Attachment #779000 - Flags: review?(karlt)
[Requesting widget:gtk peer approval, as well as build-peer approval per recent dev.platform thread, since this is a Makefile change]
Comment on attachment 779000 [details] [diff] [review]
fix v1

I assume our -Wno-error=deprecated-declarations saves us from bug 843288 here.
Attachment #779000 - Flags: review?(karlt) → review+
Indeed -- I should've mentioned that, sorry. That was added in bug 833405.
Depends on: 833405
Comment on attachment 779000 [details] [diff] [review]
fix v1

Bumping review to gps, since Ted's away.
Attachment #779000 - Flags: review?(ted) → review?(gps)
Attachment #779000 - Flags: review?(gps) → review+
Darn. Looks like that warning is tracked in bug 581478.  Hence, marking this as depending on bug 581478.
Depends on: 581478
Just pushed a fix for bug 581478, so we should be able to land this again.

I triggered a new Try run, to be sure this dir is still warning-free (since a few new files were added to widget/gtk2 in the last day or so): https://tbpl.mozilla.org/?tree=Try&rev=10ad043cb42e
https://hg.mozilla.org/mozilla-central/rev/8ad218e441d6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.