Closed
Bug 896417
Opened 12 years ago
Closed 12 years ago
Remove mouse_event_shim.js from music app
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gduan, Assigned: gduan)
References
Details
(Keywords: perf, Whiteboard: [c= p= s=2013.08.23])
Attachments
(1 file)
Refer to bug 861735 ,
We'd better remove dependency of this mouse_event_shim.js for below reasons.
1. prevent hidden bug in the future.
2. improve load time and responsiveness
3. gecko already dispatch events by itself.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → gduan
|
|
Assignee | |
Comment 1•12 years ago
|
||
1. remove mouse_event_shim.js
2. replace mouse with touch event and do some modification accordingly
Attachment #780865 -
Flags: review?(dkuo)
|
||
Comment 2•12 years ago
|
||
This is the last leg to remove the mouse shim. David - would you feel comfortable reviewing this one if Dominic can't get to it?
Flags: needinfo?(dflanagan)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 780865 [details]
Pr to master
George, thanks for working on this, the patch looks good to me. There are only two minor issues which I had commented on github, after you addressed them, the patch should be good to go.
Attachment #780865 -
Flags: review?(dkuo) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Thanks Dominic,
Merge into master
https://github.com/mozilla-b2g/gaia/commit/2f962cfb4a07853bfa0d2650e99e5a39b0cf5b27
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Whiteboard: [c= p=] → [c= p= s=2013.08.23]
You need to log in
before you can comment on or make changes to this bug.
Description
•