896752 - Windows support for the basic compositor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: WindowsBasicCompositor.patch

It basically seems to work. Aero Glass is broken if I force LAYERS_BASIC but the content area draws fine.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 779455 [details] [diff] [review]
WindowsBasicCompositor.patch

Clearing review, talked with matt woodrow and can probably get glass working

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 779455 [details] [diff] [review]
WindowsBasicCompositor.patch

I didn't have time to figure this out on my own - at the moment I'll take what we've got and not worry about glass looking bad.

Comment 3

[Nick Cameron [:nrc]]

Exactly how is glass broken? And what did you think the reason was when discussing with Matt? (In case I or someone else gets some time to look at this).

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Nick Cameron [:nrc] from comment #3)
> Exactly how is glass broken? And what did you think the reason was when
> discussing with Matt? (In case I or someone else gets some time to look at
> this).

It looks like glass doesn't render at all. It's just blank/white and iirc the control boxes didn't render either. Originally Matt thought the reason might have to do with not painting the same exact way as OnPaint (i.e., this patch ignores translucency), but after some playing around, it seemed translucency was different from the actual Aero Glass code.

Comment 5

[Bas Schouten (:bas.schouten)]

When do we use the BasicCompositor on windows at -this- point?

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Bas Schouten (:bas.schouten) from comment #5)
> When do we use the BasicCompositor on windows at -this- point?

With Electrolysis, when GPU acceleration doesn't work (unless it's guaranteed to work everywhere?)

Comment 7

[Bas Schouten (:bas.schouten)]

Comment on attachment 779455 [details] [diff] [review]
WindowsBasicCompositor.patch

Review of attachment 779455 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsWindow.cpp
@@ +3535,5 @@
> +
> +  MOZ_ASSERT(!mCompositeDC);
> +  mCompositeDC = dc;
> +
> +  return gfxPlatform::GetPlatform()->CreateDrawTargetForSurface(surf, size);

This doesn't do what you want it to do. This isn't guaranteed to be wrapping your DrawTarget (although it fill in this case), you should use the method on the Moz2D Factory.

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Uses 2d factory

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/80ceea190a42

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/80ceea190a42

Comment 11

[Benoit Girard (:BenWa)]

(In reply to David Anderson [:dvander] from comment #0)
> Aero Glass is broken if I force LAYERS_BASIC but
> the content area draws fine.

See bug 913329 for a fix.