896776 - window_manager.js should not use animation callbacks to dispose of app iframes

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

window_manager.js has a complex system of callbacks to handle animation.  These callbacks can be skipped in various situations when an animation is no longer needed for performance or correctness reasons.  Unfortunately we're also using these callbacks for disposing of resources (such as removing app iframes from the DOM) and skipping a callback results in a leak.  Either we need a separate callback system that is guaranteed to be called or we need to ensure that the animation callbacks are always called.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Kyle, thanks for filing this.
I'm working on a new system about right what you mentioned here.

See https://docs.google.com/file/d/0B8_DREosp7m2X3o4MFBqVzhkekU/edit?usp=sharing for reference, page 23.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Cool.  Let me know if there's anything I can do to help.

Comment 3

[Justin Lebar (not reading bugmail)]

Can we land bug 896825 on master as well as b2g18, so we at least fix the leak on all our trees?

Comment 4

[Andrew McCreight [:mccr8]]

I'm clearing the blocking of bug 893012, because the leak problem was fixed on trunk and b2g18 via bug 896825.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

I am confident this is resolved by bug 907013.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The existence of bug 1050751 makes it clear that this is not fixed.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

I think the real problem is not "we should not remove iframe in transitionend callback".
Removing the iframe from DOM while it's container is still closing doesn't convince me.

The real issue is at certain case the removing will be canceled, but definitely what's described in the bug summary.

Comment 8

[Eric Rahm [:erahm]]

Closing out old Firefox OS specific memshrink bugs.