Closed
Bug 896844
Opened 11 years ago
Closed 10 years ago
Wasted work in AffixMgr::defcpd_check()
Categories
(Core :: Spelling checker, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: pchang9, Assigned: pchang9)
References
Details
(Keywords: perf, Whiteboard: [fixed-in-hunspell-1.3.3])
Attachments
(1 file)
634 bytes,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0 (Beta/Release)
Build ID: 20130316161634
Steps to reproduce:
The problem appears in changeset 138350:18467a85acf6. I have attached simple one-line patches that fixes it.
In method AffixMgr::defcpd_check() in extensions/spellcheck/hunspell/src/affixmgr.cpp, the loop on line 1448 should break immediately after "ok" is set to "1". All the iterations after "ok" is set to "1" do not perform any useful work, at best they just set "ok" again to "1".
Expected results:
Break loop after "ok" is set to "1".
Updated•11 years ago
|
Component: Untriaged → Spelling checker
Product: Firefox → Core
Updated•11 years ago
|
Attachment #779562 -
Flags: review?(nemeth)
Attachment #779562 -
Flags: review?(caolanm)
Comment 1•11 years ago
|
||
looks reasonable to me, checked in now to upstream hunspell HEAD
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•11 years ago
|
Attachment #779562 -
Attachment is patch: true
Attachment #779562 -
Flags: review?(nemeth)
Attachment #779562 -
Flags: review?(caolanm)
Updated•11 years ago
|
Whiteboard: [fixed-in-hunspell-1.3.3]
Updated•10 years ago
|
Depends on: hunspell-1.3.3
Comment 2•10 years ago
|
||
Fixed on mozilla-central by bug 1022262.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → mozilla33
Updated•10 years ago
|
Assignee: nobody → pchang9
You need to log in
before you can comment on or make changes to this bug.
Description
•