Bug 1022262 (hunspell-1.3.3)

Upgrade to Hunspell 1.3.3

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jorgequinonez, Assigned: RyanVM)

Tracking

Trunk
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.76.4 (KHTML, like Gecko) Version/7.0.4 Safari/537.76.4

Steps to reproduce:

See bug 620626:
https://bugzilla.mozilla.org/show_bug.cgi?id=620626

Mozilla uses hunspell 1.3.2. Version 1.3.3 came out June 2, 2014:

http://sourceforge.net/projects/hunspell/files/Hunspell/1.3.3/
(Reporter)

Updated

4 years ago
Component: Untriaged → Spelling checker
Product: Firefox → Core
(Reporter)

Updated

4 years ago
OS: Mac OS X → All
Hardware: x86 → All

Updated

4 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

4 years ago
Alias: hunspell-1.3.3
Assignee: nobody → ryanvm
Summary: (hunspell-1.3.3) Upgrade to Hunspell 1.3.3 → Upgrade to Hunspell 1.3.3
(Assignee)

Updated

4 years ago
(Assignee)

Comment 1

4 years ago
*sigh* local changes that weren't upstreamed :(
(Assignee)

Comment 2

4 years ago
OK, I think I isolated the 8 patches that landed in-tree and were never upstreamed.
(Assignee)

Updated

4 years ago
No longer blocks: 784776
(Assignee)

Comment 3

4 years ago
Created attachment 8441072 [details] [diff] [review]
Rename the in-tree hunspell source files to use the same names as upstream

Long ago when we imported Hunspell, we renamed all the upstream .cxx files to .cpp, which makes updates a pain every time. Let's bite the bullet and just use the same names they have upstream to make our lives easier down the road.
Attachment #8441072 - Flags: review?(ehsan)
(Assignee)

Comment 4

4 years ago
Created attachment 8441074 [details] [diff] [review]
Update Hunspell to version 1.3.3

This updates our in-tree copy of Hunspell to version 1.3.3 plus some additional patches we've taken in our copy that were never upstreamed. Those 8 patches are now included in a /patches sub-directory in addition to one build fix needed to go along with undoing some of our earlier hacks from the original import. I will work on getting them upstreamed to simply our lives down the road.

Try is so far green, though I'll be waiting to push until the run is finished.
https://tbpl.mozilla.org/?tree=Try&rev=1a3d851697be
Attachment #8441074 - Flags: review?(ehsan)

Comment 5

4 years ago
Comment on attachment 8441072 [details] [diff] [review]
Rename the in-tree hunspell source files to use the same names as upstream

Review of attachment 8441072 [details] [diff] [review]:
-----------------------------------------------------------------

I assume you're also hg mv'ing the files as part of this?
Attachment #8441072 - Flags: review?(ehsan) → review+

Comment 6

4 years ago
Comment on attachment 8441074 [details] [diff] [review]
Update Hunspell to version 1.3.3

Review of attachment 8441074 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me.  Thanks for doing this!
Attachment #8441074 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/6e7a401f824b
https://hg.mozilla.org/mozilla-central/rev/9dd214468019
https://hg.mozilla.org/mozilla-central/rev/73679988dd7f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
(Assignee)

Updated

3 years ago
Depends on: 876922
(Assignee)

Updated

3 years ago
Blocks: 876922
No longer depends on: 876922
You need to log in before you can comment on or make changes to this bug.