Closed Bug 1022262 (hunspell-1.3.3) Opened 9 years ago Closed 9 years ago

Upgrade to Hunspell 1.3.3


(Core :: Spelling checker, defect)

Not set





(Reporter: jorgequinonez, Assigned: RyanVM)




(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.76.4 (KHTML, like Gecko) Version/7.0.4 Safari/537.76.4

Steps to reproduce:

See bug 620626:

Mozilla uses hunspell 1.3.2. Version 1.3.3 came out June 2, 2014:
Component: Untriaged → Spelling checker
Product: Firefox → Core
OS: Mac OS X → All
Hardware: x86 → All
Ever confirmed: true
Alias: hunspell-1.3.3
Assignee: nobody → ryanvm
Summary: (hunspell-1.3.3) Upgrade to Hunspell 1.3.3 → Upgrade to Hunspell 1.3.3
*sigh* local changes that weren't upstreamed :(
OK, I think I isolated the 8 patches that landed in-tree and were never upstreamed.
No longer blocks: 784776
Long ago when we imported Hunspell, we renamed all the upstream .cxx files to .cpp, which makes updates a pain every time. Let's bite the bullet and just use the same names they have upstream to make our lives easier down the road.
Attachment #8441072 - Flags: review?(ehsan)
This updates our in-tree copy of Hunspell to version 1.3.3 plus some additional patches we've taken in our copy that were never upstreamed. Those 8 patches are now included in a /patches sub-directory in addition to one build fix needed to go along with undoing some of our earlier hacks from the original import. I will work on getting them upstreamed to simply our lives down the road.

Try is so far green, though I'll be waiting to push until the run is finished.
Attachment #8441074 - Flags: review?(ehsan)
Comment on attachment 8441072 [details] [diff] [review]
Rename the in-tree hunspell source files to use the same names as upstream

Review of attachment 8441072 [details] [diff] [review]:

I assume you're also hg mv'ing the files as part of this?
Attachment #8441072 - Flags: review?(ehsan) → review+
Comment on attachment 8441074 [details] [diff] [review]
Update Hunspell to version 1.3.3

Review of attachment 8441074 [details] [diff] [review]:

rs=me.  Thanks for doing this!
Attachment #8441074 - Flags: review?(ehsan) → review+
Depends on: 876922
Blocks: 876922
No longer depends on: 876922
You need to log in before you can comment on or make changes to this bug.