Closed
Bug 1022262
(hunspell-1.3.3)
Opened 9 years ago
Closed 9 years ago
Upgrade to Hunspell 1.3.3
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jorgequinonez, Assigned: RyanVM)
References
Details
Attachments
(2 files)
3.97 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
194.99 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.76.4 (KHTML, like Gecko) Version/7.0.4 Safari/537.76.4 Steps to reproduce: See bug 620626: https://bugzilla.mozilla.org/show_bug.cgi?id=620626 Mozilla uses hunspell 1.3.2. Version 1.3.3 came out June 2, 2014: http://sourceforge.net/projects/hunspell/files/Hunspell/1.3.3/
Reporter | ||
Updated•9 years ago
|
Component: Untriaged → Spelling checker
Product: Firefox → Core
Reporter | ||
Updated•9 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Updated•9 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
*sigh* local changes that weren't upstreamed :(
Assignee | ||
Comment 2•9 years ago
|
||
OK, I think I isolated the 8 patches that landed in-tree and were never upstreamed.
Assignee | ||
Comment 3•9 years ago
|
||
Long ago when we imported Hunspell, we renamed all the upstream .cxx files to .cpp, which makes updates a pain every time. Let's bite the bullet and just use the same names they have upstream to make our lives easier down the road.
Attachment #8441072 -
Flags: review?(ehsan)
Assignee | ||
Comment 4•9 years ago
|
||
This updates our in-tree copy of Hunspell to version 1.3.3 plus some additional patches we've taken in our copy that were never upstreamed. Those 8 patches are now included in a /patches sub-directory in addition to one build fix needed to go along with undoing some of our earlier hacks from the original import. I will work on getting them upstreamed to simply our lives down the road. Try is so far green, though I'll be waiting to push until the run is finished. https://tbpl.mozilla.org/?tree=Try&rev=1a3d851697be
Attachment #8441074 -
Flags: review?(ehsan)
Comment 5•9 years ago
|
||
Comment on attachment 8441072 [details] [diff] [review] Rename the in-tree hunspell source files to use the same names as upstream Review of attachment 8441072 [details] [diff] [review]: ----------------------------------------------------------------- I assume you're also hg mv'ing the files as part of this?
Attachment #8441072 -
Flags: review?(ehsan) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8441074 [details] [diff] [review] Update Hunspell to version 1.3.3 Review of attachment 8441074 [details] [diff] [review]: ----------------------------------------------------------------- rs=me. Thanks for doing this!
Attachment #8441074 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e7a401f824b https://hg.mozilla.org/integration/mozilla-inbound/rev/9dd214468019
CLOBBER touched in https://hg.mozilla.org/integration/mozilla-inbound/rev/73679988dd7f for this: https://tbpl.mozilla.org/php/getParsedLog.php?id=41895157&tree=Mozilla-Inbound
https://hg.mozilla.org/mozilla-central/rev/6e7a401f824b https://hg.mozilla.org/mozilla-central/rev/9dd214468019 https://hg.mozilla.org/mozilla-central/rev/73679988dd7f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Assignee | ||
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•