1022262 - (hunspell-1.3.3) Upgrade to Hunspell 1.3.3

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Jorge Quiñónez]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.76.4 (KHTML, like Gecko) Version/7.0.4 Safari/537.76.4

Steps to reproduce:

See bug 620626:
https://bugzilla.mozilla.org/show_bug.cgi?id=620626

Mozilla uses hunspell 1.3.2. Version 1.3.3 came out June 2, 2014:

http://sourceforge.net/projects/hunspell/files/Hunspell/1.3.3/

Comment 1

[Ryan VanderMeulen [:RyanVM]]

*sigh* local changes that weren't upstreamed :(

Comment 2

[Ryan VanderMeulen [:RyanVM]]

OK, I think I isolated the 8 patches that landed in-tree and were never upstreamed.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Rename the in-tree hunspell source files to use the same names as upstream

Long ago when we imported Hunspell, we renamed all the upstream .cxx files to .cpp, which makes updates a pain every time. Let's bite the bullet and just use the same names they have upstream to make our lives easier down the road.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Update Hunspell to version 1.3.3

This updates our in-tree copy of Hunspell to version 1.3.3 plus some additional patches we've taken in our copy that were never upstreamed. Those 8 patches are now included in a /patches sub-directory in addition to one build fix needed to go along with undoing some of our earlier hacks from the original import. I will work on getting them upstreamed to simply our lives down the road.

Try is so far green, though I'll be waiting to push until the run is finished.
https://tbpl.mozilla.org/?tree=Try&rev=1a3d851697be

Comment 5

[(no longer active)]

Comment on attachment 8441072 [details] [diff] [review]
Rename the in-tree hunspell source files to use the same names as upstream

Review of attachment 8441072 [details] [diff] [review]:
-----------------------------------------------------------------

I assume you're also hg mv'ing the files as part of this?

Comment 6

[(no longer active)]

Comment on attachment 8441074 [details] [diff] [review]
Update Hunspell to version 1.3.3

Review of attachment 8441074 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me.  Thanks for doing this!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e7a401f824b
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dd214468019

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

CLOBBER touched in https://hg.mozilla.org/integration/mozilla-inbound/rev/73679988dd7f for this: https://tbpl.mozilla.org/php/getParsedLog.php?id=41895157&tree=Mozilla-Inbound

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6e7a401f824b
https://hg.mozilla.org/mozilla-central/rev/9dd214468019
https://hg.mozilla.org/mozilla-central/rev/73679988dd7f