896942 - [SMS][HD] SMS app need 1.5x ratio pictures for hd versions

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Al Tsai [:atsai]]

We need 1.5x ratio pictures. At least, we need the same files with 1.5x ratio naming.

+sms.gaiamobile.org/application/style/images/app-texture.png
+sms.gaiamobile.org/application/style/images/contact-placeholder.png
+sms.gaiamobile.org/application/style/images/conversation-view-list-bg.png
+sms.gaiamobile.org/application/style/images/diagonal-gray-pattern.png
+sms.gaiamobile.org/application/style/images/pattern.png

Comment 1

[Amy Lee [:amylee] UX]

Attachment: SMS_Assets_Bug_896942.zip

Hi, 

Attached are unscaled graphics renamed to @1.5 since these all look like textures.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/11137

Amy, thanks for the assets.

Steve, could you help review the asset change? Thanks!

Comment 3

[Steve Chung [:steveck]]

Comment on attachment 780141 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11137

Thanks for removing the unused assets and adding the repeatable images for saving the QA HD verification efforts.

Comment 4

[Wayne Chang [:wchang]]

HD+ asset bug

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.1hd: https://github.com/mozilla-b2g/gaia/commit/d8d1ff07e6c7bb494d8e580ab4e0ceae9e774543

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Please ignore comment 5. I attached the wrong commit.

v1.1hd: https://github.com/mozilla-b2g/gaia/commit/fb7752c6f6d43e8feb6693a105e15f14a4801da9

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/11211

Rex, the patch for v1.1.0hd has been reviewed by Steve. Could you help review the one for master? Thanks!

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 782403 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11211

r=me

Thanks for removing these unused assets!

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/56ec34e93f1985578a5e2f2d70f9bd0fd15dc164