896982 - [Contacts] Design and implement a component to transform mozContacts to VCARD format

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

We need to create a component that transforms mozContacts to vcard format.

The vcard formats are still to be defined, but could be added lately depending on product needs.

Also we could put this component in shared and let other applications like SMS/MMS and email benefit from it.

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

The planned vCard format is 3.0.

Comment 2

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

This function converts a single mozContact into a VCard string.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Minimun comments on the PR, looking really good!

Thanks Sergi!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 787432 [details] [diff] [review]
Github PR

Great job!

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/1b3b923534f606c69fce61136aa21849ee8bba6a

Comment 6

[James Lal [:lightsofapollo]]

Backed out: https://travis-ci.org/mozilla-b2g/gaia/builds/10023480

https://github.com/mozilla-b2g/gaia/commit/0876f713171279a8a7d39863344d3461f055e895

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This was causing Gaia unit test bustage on TBPL as well.
https://tbpl.mozilla.org/php/getParsedLog.php?id=26350355&tree=B2g-Inbound

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Ryan,

Are you referring to the strict warnings? I don't see errors or tests not passing regarding this patch.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

It was the same errors seen in comment 9, just run in a different location.

Comment 10

[Michał Budzyński (:michalbe)]

Any news on when we can expect this to land?

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Looking at it right now

Comment 12

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: New Github PR

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comments on github PR

Comment 14

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

The last PR adds the bits pointed at by Francisco. All the linting errors were fixed from the previous pass, and my tests pass when testing mozContact2vcard individually or along with the contacts suite, and they pass both in Gecko 18 and latest nightly.

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 792168 [details] [diff] [review]
New Github PR

All tests passed locally, working fine for me.

Thanks Sergi

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/b8c80a322c8f52e05690ecd7afc286342095059e