Closed Bug 897090 Opened 8 years ago Closed 8 years ago

[Clock] L10n mocking is fragmented across test files

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Clock
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jugglinmike, Assigned: jugglinmike)

References

Details

Attachments

(1 file)

Share l10n stubbing across unit tests
2.31 KB, patch
iliu
: review+
Details | Diff | Splinter Review 
All of Clock's unit tests should use a stubbed implementation of the `mozL10n` object. We can minimize duplication by setting up this stub in an `setup.js` file within the `test/unit/` directory.
Hey Ian,

I've also submitted this as a pull request on GitHub, in case that is how you prefer to conduct code reviews: https://github.com/mozilla-b2g/gaia/pull/11128
Attachment #779847 - Flags: review?(iliu)
Depends on: 897089
Blocks: 897103
Blocks: 897117
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Comment on attachment 779847 [details] [diff] [review]
Share l10n stubbing across unit tests

Review of attachment 779847 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good for me.
Attachment #779847 - Flags: review?(iliu) → review+
Blocks: 898666
Landed on `master` at commit 7247cae4e984a13616d3ca8750280b8e2273e4da

Thanks for the review, Ian!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.