[Clock] Utility methods are not fully covered by unit tests

RESOLVED FIXED

Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jugglinmike, Assigned: jugglinmike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

3.11 KB, patch
iliu@mozilla.com, ianliu.moz@gmail.com
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
Not all utility methods have associated unit tests
(Assignee)

Comment 1

4 years ago
Created attachment 779855 [details] [diff] [review]
Test utility methods

Hey Ian,

I've also submitted this work as a pull request on GitHub: https://github.com/mozilla-b2g/gaia/pull/11129
Attachment #779855 - Flags: review?(iliu)
Comment on attachment 779855 [details] [diff] [review]
Test utility methods

Review of attachment 779855 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good for the two unitest cases 'isAlarmPassToday', 'changeSelectByValue'. Thanks:)
Attachment #779855 - Flags: review?(iliu) → review+
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Blocks: 898666
(Assignee)

Comment 3

4 years ago
Landed on `master` at commit f17ad1ba168e45ccc4c2cbd61b13a3233784645c

Thanks for the review, Ian!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.