Closed
Bug 897103
Opened 12 years ago
Closed 12 years ago
[Clock] Utility methods are not fully covered by unit tests
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jugglinmike, Assigned: jugglinmike)
References
Details
Attachments
(1 file)
|
3.11 KB,
patch
|
iliu
:
review+
|
Details | Diff | Splinter Review |
Not all utility methods have associated unit tests
|
Assignee | |
Comment 1•12 years ago
|
||
Hey Ian,
I've also submitted this work as a pull request on GitHub: https://github.com/mozilla-b2g/gaia/pull/11129
Attachment #779855 -
Flags: review?(iliu)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 779855 [details] [diff] [review]
Test utility methods
Review of attachment 779855 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good for the two unitest cases 'isAlarmPassToday', 'changeSelectByValue'. Thanks:)
Attachment #779855 -
Flags: review?(iliu) → review+
|
|
||
Updated•12 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
|
|
Assignee | |
Comment 3•12 years ago
|
||
Landed on `master` at commit f17ad1ba168e45ccc4c2cbd61b13a3233784645c
Thanks for the review, Ian!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•