Closed Bug 897099 Opened 8 years ago Closed 8 years ago

Work - Circular Progressbar Images

Categories

(Tracking Graveyard :: Metro Operations, defect)

x86_64
Windows 8
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emtwo, Assigned: sfoster)

References

Details

(Whiteboard: [preview])

Attachments

(5 files)

Attached image progress.png
Stephen, would we be able to get some images for the circular downloads progress indicator? I've attached a screenshot from the downloads doc here https://bug876019.bugzilla.mozilla.org/attachment.cgi?id=761217

We need a full blue circle that looks similar to the one in the image. Also, perhaps a grey circle that would go behind the blue one or an entire download image which includes the grey circle. Either works. Thanks!
Assignee: nobody → shorlander
Blocks: 883959
Whiteboard: [preview]
Blocks: 905641
Duplicate of this bug: 905641
I ended up adding a track/background element in the binding to take the ring-background image. That made it easier to toggle it with the "progress" attribute. 
I also found some scaling/skewing of the image due to a mismatch of image/element size and was able to clean that up.
Assignee: shorlander → sfoster
Status: NEW → ASSIGNED
Attachment #795712 - Flags: review?(mbrubeck)
This is how it ends up looking.
Comment on attachment 795712 [details] [diff] [review]
Update downloads progress ring graphics

Review of attachment 795712 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/bindings/circularprogress.xml
@@ +11,5 @@
>    <binding id="circular-progress-indicator">
>      <content>
>        <xul:stack>
>          <xul:toolbarbutton anonid="progressButton" class="circularprogressindicator-progressButton appbar-secondary"/>
> +        <html:div anonid="progressTrack" class="circularprogressindicator-progressTrack"></html:div>

Suggestion: You could use inherits="progress" here to simplify the CSS selectors.
Attachment #795712 - Flags: review?(mbrubeck) → review+
Good thought mbrubeck. Done (or at least I think that's what you had in mind) 

On fx-team: https://hg.mozilla.org/integration/fx-team/rev/f30dadf4c937
https://hg.mozilla.org/mozilla-central/rev/f30dadf4c937
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Tracking → Tracking Graveyard
You need to log in before you can comment on or make changes to this bug.