Closed Bug 897476 Opened 7 years ago Closed 6 years ago

Hook up web console, style editor and profiler

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 27.0

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file, 2 obsolete files)

This bug handles making sure the web console, style editor and profiler work. This seems to be just a matter of starting the actors.

Also, this patch contains a fix that breaks the window.console object on the main window. I can split that out for aurora+beta if needed.

This bug needs bug 880511 fixed to actually be useful, but the changes don't break anything without it.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attached patch Fix - v1 (obsolete) β€” β€” Splinter Review
Attachment #780415 - Flags: review?(mconley)
Comment on attachment 780415 [details] [diff] [review]
Fix - v1

Review of attachment 780415 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! Sorry about the wait!
Attachment #780415 - Flags: review?(mconley) → review+
Attached patch Fix - v2 (obsolete) β€” β€” Splinter Review
Ok, so here is a better version. This is what changed:

* Now using addBrowserActors, so we always use the latest code from devtools. 
  I guess there could be debate about the name, but whatever.
* React to devtools changes to promisify the iterate function (rename 
  to getList)
* Added the addonList part that also changed in devtools. This will prepare us
  if we want to add any extensions that add actors.
Attachment #780415 - Attachment is obsolete: true
Attachment #803361 - Flags: review?(mconley)
Note: patch v2 doesn't add the global style editor actor anymore. This will be handled in devtools with bug 915444.
Comment on attachment 803361 [details] [diff] [review]
Fix - v2

Review of attachment 803361 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/debugger/content/dbg-mail-actors.js
@@ +5,4 @@
>  Components.utils.import("resource://gre/modules/iteratorUtils.jsm");
>  Components.utils.import("resource://gre/modules/Services.jsm");
>  
> +let promise = Cu.import("resource://gre/modules/commonjs/sdk/core/promise.js", {}).Promise;

I thought resource://gre/modules/Promise.jsm was the new hotness, but I guess we'll want to all use the same Promise implementation, and b2g can't use the jsm's. Right?
Attachment #803361 - Flags: review?(mconley) → review+
(In reply to Mike Conley (:mconley) from comment #5)
> ::: mail/components/debugger/content/dbg-mail-actors.js
> @@ +5,4 @@
> >  Components.utils.import("resource://gre/modules/iteratorUtils.jsm");
> >  Components.utils.import("resource://gre/modules/Services.jsm");
> >  
> > +let promise = Cu.import("resource://gre/modules/commonjs/sdk/core/promise.js", {}).Promise;
> 
> I thought resource://gre/modules/Promise.jsm was the new hotness, but I
> guess we'll want to all use the same Promise implementation, and b2g can't
> use the jsm's. Right?

I'm using the same promise implementation used by the other devtools actors, I'd like to wait until devtools switches before we do to avoid any incompatibilities.
Attached patch Fix - v3 β€” β€” Splinter Review
Patch for checkin
Attachment #803361 - Attachment is obsolete: true
Attachment #811514 - Flags: review+
https://hg.mozilla.org/comm-central/rev/f3f521ffcdaa
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 27.0
You need to log in before you can comment on or make changes to this bug.