897696 - Defect - Geolocation doesn't work in metrofx

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[Samvedana (:Samvedana)]

Attachment: locate me.PNG

Tested user story of bug 831949 on Windows 8.1 preview for Metro Firefox.
When I opened http://ie.microsoft.com/TESTdrive/HTML5/Geolocation/Default.html in latest nightly and click on locate me. It didn't give me location.

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:25.0) Gecko/20130724 Firefox/25.0
Build ID: 20130724030204

Comment 1

[Jim Mathies [:jimm]]

This doesn't work on desktop either.

Comment 2

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #1)
> This doesn't work on desktop either.

Works on Win7, but not Win8.

Comment 3

[Jim Mathies [:jimm]]

Maybe this is just with the wifi adpater or has something to do with using nightly to test. Log output:

[08:55:13.497] *** WIFI GEO: startup called.  testing mode isfalse

[08:55:13.497] *** WIFI GEO: watch called

[08:55:13.504] *** WIFI GEO: onChange called

[08:55:13.504] *** WIFI GEO: Filtering out Tigger

[08:55:13.504] *** WIFI GEO: Filtering out Tigger5G

[08:55:13.504] *** WIFI GEO: Filtering out 323

[08:55:13.505] *** WIFI GEO: ************************************* Sending request:
https://www.googleapis.com/geolocation/v1/geolocate?key=no-google-api-key


[08:55:13.505] *** WIFI GEO: ************************************* ------>>>> sending {"wifiAccessPoints":[{"macAddress":"60-a4-4c-20-11-20","signalStrength":-30},{"macAddress":"snip","signalStrength":-83},{"macAddress":"snip","signalStrength":-100}]}

[08:55:13.565] POST https://www.googleapis.com/geolocation/v1/geolocate?key=no-google-api-key [HTTP/1.1 400 Bad Request 495ms]
[08:55:14.008] *** WIFI GEO: gls returned status: 400 --> {"error":{"errors":[{"domain":"usageLimits","reason":"keyInvalid","message":"Bad Request"}],"code":400,"message":"Bad Request"}}

Comment 4

[Jim Mathies [:jimm]]

Although nightly on Win7 works fine from the same location FWIW. Both devices are connected via network adapters.

Comment 5

[Jim Mathies [:jimm]]

Doug, any ideas as to what's going wrong here?

Comment 6

[Doug Turner (:dougt)]

yeah, the builders aren't using the right google key.  This is a releng bug.

Comment 8

[Jim Mathies [:jimm]]

Ok, so I've been able to reproduce bugs in our geolocation test page on win7 and win8. U can confirm thatafter a few refreshes I was able to get IE's demo working in desktop, but not in metro.

Comment 9

[Jim Mathies [:jimm]]

Attachment: geolocation test page

Comment 10

[Jim Mathies [:jimm]]

Ok, after bouncing this around, I can confirm we do in fact have an issue with geolocation in the metro browser. The posted test page is useful in testing.

Comment 11

[Jim Mathies [:jimm]]

Attachment: fix

Unfortunately, I can't test this in a local build, afaict. %GOOGLE_API_KEY% gets filled in with 'no-google-api-key'. But I'm betting in a Nightly this will get populated correctly.

Comment 12

[Jim Mathies [:jimm]]

Yeah, looks like we add this when we build - 

http://mxr.mozilla.org/mozilla-central/source/configure.in#4404

Comment 13

[Doug Turner (:dougt)]

:)

Comment 14

[Jim Mathies [:jimm]]

Comment on attachment 781101 [details] [diff] [review]
fix

I think doug is trying to tell me he can't do this review, not sure but just to be safe.

Comment 15

[Matt Brubeck (:mbrubeck)]

Comment on attachment 781101 [details] [diff] [review]
fix

Doug, should we make the default in modules/libpref/src/init/all.js?  Will Fennec or B2G need this too?

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b71e4f85dad6

Comment 17

[Manuela Muntean [Away]]

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130728 Firefox/25.0

Verified as fixed on the latest Nightly build using the steps from the description. The location is now visible.

Comment 18

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130808030205
Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0

WFM
Tested on windows 8 using latest nightly for iteration-11 for bug831949. Followed steps provided in user story and didn't provide geolocation.

It is also not working for desktop Firefox.

Comment 19

[Marco Mucci [:MarcoM]]

Moving follow-up fix to Bug 898795.

Comment 20

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205
Built from http://hg.mozilla.org/mozilla-central/rev/c8c9bd74cc40

WFM
Tested on windows 8.1 using latest nightly. Followed steps provided in comment0 and got expected result.

Comment 21

[Manuela Muntean [Away]]

While testing for iteration #15, this doesn't work with latest Nightly and both desktop and Metro mode (build ID: 20131006030201)

Comment 22

[Manuela Muntean [Away]]

While testing for iteration #17, this doesn't work with latest Nightly in Metro mode, but it does work with Nightly in desktop mode. (build ID: 20131101030205)

Comment 23

[Jim Mathies [:jimm]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #22)
> While testing for iteration #17, this doesn't work with latest Nightly in
> Metro mode, but it does work with Nightly in desktop mode. (build ID:
> 20131101030205)

Dupe of bug 933075?

Comment 24

[Manuela Muntean [Away]]

(In reply to Jim Mathies [:jimm] from comment #23)
> (In reply to Manuela Muntean [:Manuela] [QA] from comment #22)
> > While testing for iteration #17, this doesn't work with latest Nightly in
> > Metro mode, but it does work with Nightly in desktop mode. (build ID:
> > 20131101030205)
> 
> Dupe of bug 933075?

I think that bug 933075 depends on this one, bug 897696. (but I don't think they are duplicates)