897834 - B2G Emulator: Refactor the fall-through flow for RIL_REQUEST in reference-ril

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

The fall-through flow for RIL_REQUEST [1] in reference-ril has some potential problems.
* It is easy to break the flow by changing the sequence and finally run into an unexpected case block.
* Can not base on this flow to have the same check for GSM specific requests.

Maybe we should have a separated switch-case for CDMA/GSM specific request set. It seems more clear and more easily to maintain.

Thanks

[1] https://github.com/mozilla-b2g/platform_hardware_ril/blob/ec665107b24b2002e45d9de5236536130d7b1827/reference-ril/reference-ril.c#L2434

Comment 1

[Edgar Chen [:edgar]]

Attachment: hardware/ril pull request #21

Comment 2

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/platform_hardware_ril/pull/21#issuecomment-21698812

Pointer to Github pull-request

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 782408 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/platform_hardware_ril/pull/21#issuecomment-21698812

oops! Was just browsing accidentally hit the attach button...

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 780889 [details]
hardware/ril pull request #21

nit: TECH_BIT(sMdmInfo) & (MDM_CDMA | MDM_EVDO).  Will merge after this nit addressed.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Merged on GitHub: https://github.com/mozilla-b2g/platform_hardware_ril/commit/3ee3eba20f763699b3d711839fed972c999daf85