Closed
Bug 897909
Opened 12 years ago
Closed 12 years ago
Cleanup some SIMPLE_PROGRAMS
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
15.66 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
|
4.64 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
It's a bit of a mess, I hope this improves things.
Attachment #780888 -
Flags: review?(gps)
|
Assignee | |
Updated•12 years ago
|
Blocks: nomakefiles
|
|
Assignee | |
Comment 1•12 years ago
|
||
Found another file.
Attachment #780888 -
Attachment is obsolete: true
Attachment #780888 -
Flags: review?(gps)
Attachment #780899 -
Flags: review?(gps)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 780899 [details] [diff] [review]
Patch v1.1
Review of attachment 780899 [details] [diff] [review]:
-----------------------------------------------------------------
I'm happy if try is happy.
I really wish we had a decent grammar for representing binaries. This is quickly growing out of hand...
Attachment #780899 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
I seem to have missed some.
Attachment #784905 -
Flags: review?(gps)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 784905 [details] [diff] [review]
Some more
Review of attachment 784905 [details] [diff] [review]:
-----------------------------------------------------------------
::: tools/codesighs/moz.build
@@ +19,1 @@
> 'nm2tsv.c',
Consider these .c's gone.
|
|
Assignee | |
Comment 5•12 years ago
|
||
Review ping.
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 784905 [details] [diff] [review]
Some more
Review of attachment 784905 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the review lag.
Attachment #784905 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•