897909 - Cleanup some SIMPLE_PROGRAMS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

It's a bit of a mess, I hope this improves things.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1.1

Found another file.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 780899 [details] [diff] [review]
Patch v1.1

Review of attachment 780899 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy if try is happy.

I really wish we had a decent grammar for representing binaries. This is quickly growing out of hand...

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Some more

I seem to have missed some.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 784905 [details] [diff] [review]
Some more

Review of attachment 784905 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/codesighs/moz.build
@@ +19,1 @@
>          'nm2tsv.c',

Consider these .c's gone.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Review ping.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 784905 [details] [diff] [review]
Some more

Review of attachment 784905 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the review lag.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/fdeb80c577b3