Cleanup some SIMPLE_PROGRAMS

RESOLVED FIXED in mozilla26

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla26
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 780888 [details] [diff] [review]
Patch v1

It's a bit of a mess, I hope this improves things.
Attachment #780888 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Blocks: 847009
(Assignee)

Comment 1

5 years ago
Created attachment 780899 [details] [diff] [review]
Patch v1.1

Found another file.
Attachment #780888 - Attachment is obsolete: true
Attachment #780888 - Flags: review?(gps)
Attachment #780899 - Flags: review?(gps)

Comment 2

5 years ago
Comment on attachment 780899 [details] [diff] [review]
Patch v1.1

Review of attachment 780899 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy if try is happy.

I really wish we had a decent grammar for representing binaries. This is quickly growing out of hand...
Attachment #780899 - Flags: review?(gps) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 784905 [details] [diff] [review]
Some more

I seem to have missed some.
Attachment #784905 - Flags: review?(gps)
(Assignee)

Comment 4

5 years ago
Comment on attachment 784905 [details] [diff] [review]
Some more

Review of attachment 784905 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/codesighs/moz.build
@@ +19,1 @@
>          'nm2tsv.c',

Consider these .c's gone.
(Assignee)

Comment 5

5 years ago
Review ping.

Comment 6

5 years ago
Comment on attachment 784905 [details] [diff] [review]
Some more

Review of attachment 784905 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the review lag.
Attachment #784905 - Flags: review?(gps) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fdeb80c577b3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

Updated

4 years ago
See Also: → bug 872086
You need to log in before you can comment on or make changes to this bug.