Remove the try/catch in SocialUI.observe now that bug 895340 has been fixed

RESOLVED FIXED in Firefox 34

Status

defect
RESOLVED FIXED
6 years ago
4 months ago

People

(Reporter: jaws, Assigned: hharchani)

Tracking

Trunk
Firefox 34

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 895340 was fixed, so exceptions thrown in an observer callback will properly get reported. This means we can now remove the try/catch at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#79
Assignee

Comment 1

5 years ago
Posted patch bug-898166.patch (obsolete) — Splinter Review
Removed try/catch and the comment regarding that too.
Removed blank lines between few case in switch.
Attachment #8479469 - Flags: review?(mhammond)
Comment on attachment 8479469 [details] [diff] [review]
bug-898166.patch

Review of attachment 8479469 [details] [diff] [review]:
-----------------------------------------------------------------

The blank lines were *almost* providing value - but I think I can live without them :)  Thanks!
Attachment #8479469 - Flags: review?(mhammond) → review+
Assignee: nobody → hharchani
Assignee

Updated

5 years ago
Keywords: checkin-needed
This patch landed with the wrong reviewer in the commit message. It should have said r=markh.
Assignee

Comment 5

5 years ago
Oh sorry, forgot to add. Added r=markh :)
Attachment #8479469 - Attachment is obsolete: true
Attachment #8480030 - Flags: review?(mhammond)
Comment on attachment 8480030 [details] [diff] [review]
bug-898166.patch

Not your fault Harshit :)

I just wanted to comment in here to note for RyanVM that he might have a script that made an error (or human error).

The patch has already landed and will probably make it in to tomorrow's Nightly build. Thanks and nice job!
Attachment #8480030 - Flags: review?(mhammond)
Assignee

Comment 7

5 years ago
Oh ok. I'm new here so I actually didn't knew the patch was landed so I corrected the commit msg and resubmited.
https://hg.mozilla.org/mozilla-central/rev/d12b4ff6d126
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Whiteboard: [qa-]

Updated

4 months ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.