Closed
Bug 898166
Opened 11 years ago
Closed 10 years ago
Remove the try/catch in SocialUI.observe now that bug 895340 has been fixed
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: jaws, Assigned: hharchani)
Details
Attachments
(1 file, 1 obsolete file)
5.55 KB,
patch
|
Details | Diff | Splinter Review |
Bug 895340 was fixed, so exceptions thrown in an observer callback will properly get reported. This means we can now remove the try/catch at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#79
Removed try/catch and the comment regarding that too. Removed blank lines between few case in switch.
Attachment #8479469 -
Flags: review?(mhammond)
Comment 2•10 years ago
|
||
Comment on attachment 8479469 [details] [diff] [review] bug-898166.patch Review of attachment 8479469 [details] [diff] [review]: ----------------------------------------------------------------- The blank lines were *almost* providing value - but I think I can live without them :) Thanks!
Attachment #8479469 -
Flags: review?(mhammond) → review+
Updated•10 years ago
|
Assignee: nobody → hharchani
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d12b4ff6d126
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Reporter | ||
Comment 4•10 years ago
|
||
This patch landed with the wrong reviewer in the commit message. It should have said r=markh.
Oh sorry, forgot to add. Added r=markh :)
Attachment #8479469 -
Attachment is obsolete: true
Attachment #8480030 -
Flags: review?(mhammond)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8480030 [details] [diff] [review] bug-898166.patch Not your fault Harshit :) I just wanted to comment in here to note for RyanVM that he might have a script that made an error (or human error). The patch has already landed and will probably make it in to tomorrow's Nightly build. Thanks and nice job!
Attachment #8480030 -
Flags: review?(mhammond)
Oh ok. I'm new here so I actually didn't knew the patch was landed so I corrected the commit msg and resubmited.
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d12b4ff6d126
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
QA Whiteboard: [qa-]
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•