nsXULPrototypeCache.cpp:208:19: warning: unused variable 'existingScript' [-Wunused-variable]

RESOLVED FIXED in mozilla25

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla25
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 896506's patch left us with an unused variable in nsXULPrototypeCache::PutScript(), triggering a build warning:
{
content/xul/document/src/nsXULPrototypeCache.cpp: In member function 'nsresult nsXULPrototypeCache::PutScript(nsIURI*, JS::Handle<JSScript*>)':

content/xul/document/src/nsXULPrototypeCache.cpp:208:19: warning: unused variable 'existingScript' [-Wunused-variable]
     if (JSScript* existingScript = mScriptTable.Get(aURI)) {
}

Looks like we can just drop "JSScript* existingScript = "
Posted patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #781394 - Flags: review?(bugs)
Attachment #781394 - Flags: review?(bugs) → review?(jcoppeard)
Blocks: 898489
Comment on attachment 781394 [details] [diff] [review]
fix

Review of attachment 781394 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the warning!

The fix looks good.
Attachment #781394 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/6db27e6a0739
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.