Closed Bug 898489 Opened 7 years ago Closed 7 years ago

Mark content/xul/content/src/ and content/xul/document/src/ as FAIL_ON_WARNINGS

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

With bug 898232 fixed, content/xul/content/src/ and content/xul/document/src/ are build-warning-free.

Filing this bug on annotating them as FAIL_ON_WARNINGS, to hopefully keep it that way.
Attached patch fixSplinter Review
Attachment #781756 - Flags: review?(bugs)
Comment on attachment 781756 [details] [diff] [review]
fix

r?gps, since this is a Makefile tweak.
Attachment #781756 - Flags: review?(gps)
Successful try run:
 https://tbpl.mozilla.org/?tree=Try&rev=8347913fa14a

(The Win7 oranges are for some sort of issue during "make check", after the build has completed, so it's unrelated to this.)
Attachment #781756 - Flags: review?(gps) → review+
Attachment #781756 - Flags: review?(bugs) → review+
Landed bug 898232 on inbound, so this should be good to go.

I triggered one more sanity-check try run with up-to-date m-i, since a few days have passed:
 https://tbpl.mozilla.org/?tree=Try&rev=e516fc61aa38
Today's try run has completed at least one build (one of opt or debug) on all platform, so I went ahead and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/5375b4e2b7c2
https://hg.mozilla.org/mozilla-central/rev/5375b4e2b7c2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.