898489 - Mark content/xul/content/src/ and content/xul/document/src/ as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Daniel Holbert [:dholbert]]

With bug 898232 fixed, content/xul/content/src/ and content/xul/document/src/ are build-warning-free.

Filing this bug on annotating them as FAIL_ON_WARNINGS, to hopefully keep it that way.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 781756 [details] [diff] [review]
fix

r?gps, since this is a Makefile tweak.

Comment 3

[Daniel Holbert [:dholbert]]

Successful try run:
 https://tbpl.mozilla.org/?tree=Try&rev=8347913fa14a

(The Win7 oranges are for some sort of issue during "make check", after the build has completed, so it's unrelated to this.)

Comment 4

[Daniel Holbert [:dholbert]]

Landed bug 898232 on inbound, so this should be good to go.

I triggered one more sanity-check try run with up-to-date m-i, since a few days have passed:
 https://tbpl.mozilla.org/?tree=Try&rev=e516fc61aa38

Comment 5

[Daniel Holbert [:dholbert]]

Today's try run has completed at least one build (one of opt or debug) on all platform, so I went ahead and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/5375b4e2b7c2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5375b4e2b7c2