#error qmetatype.h must be included before any header file that defines Bool

RESOLVED FIXED in mozilla25

Status

RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: tatiana, Assigned: Ms2ger)

Tracking

Trunk
mozilla25
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Qt Firefox fails to build:

c++ -o PluginModuleParent.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /home/nebel/mozilla-upstream/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL  -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -DFORCE_PR_LOG -I/home/nebel/mozilla-upstream/dom/plugins/ipc/../base -I/home/nebel/mozilla-upstream/xpcom/base/  -I/home/nebel/mozilla-upstream/ipc/chromium/src -I/home/nebel/mozilla-upstream/ipc/glue -I../../../ipc/ipdl/_ipdlheaders  -I/home/nebel/mozilla-upstream/dom/plugins/ipc -I. -I../../../dist/include  -I/home/nebel/mozilla-upstream/obj-browser-qt-debug/dist/include/nspr -I/home/nebel/mozilla-upstream/obj-browser-qt-debug/dist/include/nss      -fPIC  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe  -DDEBUG -D_DEBUG -DTRACING -g -Os -freorder-blocks  -fno-omit-frame-pointer   -I/usr/include/qt5/QtGui -I/usr/include/qt5 -I/usr/include/qt5/QtCore -I/usr/include/qt5/QtNetwork -I/usr/include/qt5/QtOpenGL -I/usr/include/qt5/QtWidgets -I/usr/include/qt5/QtPrintSupport   -I/usr/include/qt5/QtGui/5.0.2/QtGui -I/home/nebel/mozilla-upstream/obj-browser-qt-debug/dist/include/cairo   -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/PluginModuleParent.o.pp  /home/nebel/mozilla-upstream/dom/plugins/ipc/PluginModuleParent.cpp
In file included from /usr/include/qt5/QtCore/qobject.h:55:0,
                 from /usr/include/qt5/QtCore/qcoreapplication.h:45,
                 from /usr/include/qt5/QtCore/QCoreApplication:1,
                 from /home/nebel/mozilla-upstream/dom/plugins/ipc/PluginModuleParent.cpp:43:
/usr/include/qt5/QtCore/qmetatype.h:56:2: error: #error qmetatype.h must be included before any header file that defines Bool
/usr/include/qt5/QtCore/qmetatype.h:205:9: error: expected identifier before ‘int’
...
(Reporter)

Updated

5 years ago
Blocks: 896275
(Assignee)

Comment 1

5 years ago
Ugh. Do you know what defines Bool?
(Reporter)

Comment 2

5 years ago
Xlib.h included from npapi.h defines Bool. These four include npapi.h:

#include "mozilla/plugins/PluginModuleParent.h"
#include "mozilla/plugins/BrowserStreamParent.h"
#include "nsNPAPIPlugin.h"
#include "PluginIdentifierParent.h"
(Assignee)

Comment 3

5 years ago
Created attachment 782486 [details] [diff] [review]
Patch v1

Can you check if this helps?
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #782486 - Flags: feedback?(tanya.meshkova)
(Reporter)

Comment 4

5 years ago
Created attachment 782783 [details]
build log
(Reporter)

Comment 5

5 years ago
Created attachment 782788 [details]
qmetatype.h
(Reporter)

Comment 6

5 years ago
Comment on attachment 782486 [details] [diff] [review]
Patch v1

It doesn't. See the log above.
Attachment #782486 - Flags: feedback?(tanya.meshkova) → feedback-
(Reporter)

Updated

5 years ago
Attachment #782788 - Attachment mime type: text/x-chdr → text/plain
(Assignee)

Comment 7

5 years ago
Created attachment 783028 [details] [diff] [review]
Patch v2

I hate C++. How about this?
Attachment #782486 - Attachment is obsolete: true
Attachment #783028 - Flags: superreview?(tanya.meshkova)
(Reporter)

Updated

5 years ago
Attachment #783028 - Flags: superreview?(tanya.meshkova) → feedback+
(Assignee)

Updated

5 years ago
Attachment #783028 - Flags: review?(mounir)
Attachment #783028 - Flags: review?(mounir) → review+
Attachment #783028 - Flags: checkin?
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

5 years ago
Yes, I'll land it, thanks for the reminders.
Keywords: checkin-needed
Attachment #783028 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/f307c0643e69
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.