898409 - [User Story] Data Settings Runtime Customization by SIM

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Peter Dolanjski [:pdol]]

User Story:

As an OEM, I want to be able to specify which data APN, Identifer, Password, HTTP proxy host and HTTP proxy port should be used on the device based on the MNC/MCC setting from the SIM card inserted in order to target customizations to locales without needing to use separate builds.


Acceptance Criteria:

1. If a certain data settings (including APN, Identifier, Password, HTTP proxy host and HTTP proxy port) are specified to be included for an MNC/MCC combination, and a SIM card with that MNC/MCC combination is inserted into the device the data settings used by the device are those specified.
2. If no SIM card is inserted, the specified default data settings are used by the device.

Note: this functionality already exists - this user story is just to ensure the inclusion of integration tests and QA test verification.

Comment 1

[Aus Lacroix [:aus]]

This bug should tackle the bugs that are marked blocking at the same time. Data, MMS and A-GPS settings are all handled by the same underlying code.

Comment 2

[Candice Serran (:cserran)]

Ghislain 'Aus' Lacroix changed story state to started in Pivotal Tracker

Comment 3

[Aus Lacroix [:aus]]

Attachment: Patch - v2 - Update Operator Variant to use new common helper, Add much needed unit tests!

Comment 4

[Aus Lacroix [:aus]]

This patch fixes dependent bug 898410.

Comment 5

[Fabien Cazenave [:kaze]]

Comment on attachment 800951 [details]
Patch - v2 - Update Operator Variant to use new common helper, Add much needed unit tests!

apn.json is dynamically generated: please don’t update it manually. Instead, you should add your data to apn_conf_local.xml and regenerate apn.json.

Feel free to r? me again when you update your PR.

Comment 6

[Aus Lacroix [:aus]]

Comment on attachment 800951 [details]
Patch - v2 - Update Operator Variant to use new common helper, Add much needed unit tests!

Same pull-request but with the requested updates. Used apns_conf_local.xml to add the appropriate test network values and regenerated apn.json. Other minor updates to ensure settings load appropriately and to unit tests.

Comment 7

[Aus Lacroix [:aus]]

From IRC:

kaze			will r+ as soon as bugzilla is back			1:43
kaze			yes!

Looks like he hasn't gotten to hit bugzilla but the pull request is green and ready to merge so I'm going to go ahead and do that.

Comment 8

[Aus Lacroix [:aus]]

Fixed: https://github.com/mozilla-b2g/gaia/commit/cfcea746250d7c6ea01a389c3d7714c471f28641

Comment 9

[Candice Serran (:cserran)]

Ghislain 'Aus' Lacroix changed story state to finished in Pivotal Tracker

Comment 10

[Candice Serran (:cserran)]

Ghislain 'Aus' Lacroix changed story state to accepted in Pivotal Tracker

Comment 11

[Candice Serran (:cserran)]

Ghislain 'Aus' Lacroix changed story state to accepted in Pivotal Tracker

Comment 12

[Fabien Cazenave [:kaze]]

Comment on attachment 800951 [details]
Patch - v2 - Update Operator Variant to use new common helper, Add much needed unit tests!

Thanks for merging. :-)

Comment 13

[Anthony Ricaud (:rik)]

I had to revert this since it is failing one unit test.

https://github.com/mozilla-b2g/gaia/commit/8b15a3359fc30f3703808763e976cfcab3812724

[system] WiFi > "before each" hook:
TypeError: setting a property that has only a getter
at (anonymous) (http://system.gaiamobile.org:8080/test/unit/wifi_test.js:104)
at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:60)
at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 14

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch - v3 - Update Operator Variant to use new common helper, Add much needed unit tests!

Original test failed wifi tests due to mozPower not being set writable. All this pull request does is revert the revert on github, and add a patch on top to fix writable property, as well as remove unused stubMozPower variable.

Need this fixed to land Bug 891725.

Comment 15

[Jason Smith [:jsmith]]

(In reply to Anthony Ricaud (:rik) from comment #13)
> I had to revert this since it is failing one unit test.
> 
> https://github.com/mozilla-b2g/gaia/commit/
> 8b15a3359fc30f3703808763e976cfcab3812724
> 
> [system] WiFi > "before each" hook:
> TypeError: setting a property that has only a getter
> at (anonymous) (http://system.gaiamobile.org:8080/test/unit/wifi_test.js:104)
> at wrapper
> (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:60)
> at run
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
> at next
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
> at (anonymous)
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
> at (anonymous)
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

This also caused bug 915218 as well. Thanks for backing this out.

Comment 16

[Fabien Cazenave [:kaze]]

Comment on attachment 803046 [details] [diff] [review]
Patch - v3 - Update Operator Variant to use new common helper, Add much needed unit tests!

Looks good to me, but redirecting the review to Jose who knows this part better than anyone.

Comment 17

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 803046 [details] [diff] [review]
Patch - v3 - Update Operator Variant to use new common helper, Add much needed unit tests!

PR closed. Clearing the review flag here.

Comment 18

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Landed as part of pull request for Bug 891725, which also contained revert revert and fix. A sad mess I will try not to repeat.

https://github.com/mozilla-b2g/gaia/pull/12121

Comment 19

[Jason Smith [:jsmith]]

Aus - In order to test this, I need to get a sample customization showcasing how this would be setup in a real customization. Can you provide a sample?

Comment 20

[Aus Lacroix [:aus]]

See https://github.com/mozilla-b2g/gaia/tree/master/shared/resources/apn for the README.md

See https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn.json#L3179 for what is the final output file that we actually load and parse at run-time. I pointed you to the test data we use.

The 'default' settings are what is used for all basic data connectivity.

Comment 21

[Jason Smith [:jsmith]]

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2253