898457 - Defect - Horizontal scroll bar visible in settings and about panels

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

Description

[Kapranov]

Attachment: Снимок экрана (72).png

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

There was a horizontal scroll in the settings panel and about, which are not needed. Appeared after the application of fixation https://hg.mozilla.org/mozilla-central/rev/1cf7aa4b2626

Comment 1

[Kapranov]

FIX:
diff --git a/browser/metro/theme/flyoutpanel.css b/browser/metro/theme/flyoutpanel.css
.flyoutpanel-contents[input="precise"] {
 overflow: scroll;
 overflow-x: hidden;
 }

Comment 2

[Asa Dotzler [:asa]]

I see this too in the latest nightly with a standard dpi display.

Comment 3

[Jim Mathies [:jimm]]

My mistake I guess, thought we wanted scrollbars to be visible in panels like this when in precise mode. Thanks for posted the fix Kapranov.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #3)
> My mistake I guess, thought we wanted scrollbars to be visible in panels
> like this when in precise mode. Thanks for posted the fix Kapranov.

Oh nm, it's the horizontal bar that's the issue.

Comment 5

[Jim Mathies [:jimm]]

Attachment: fix

Comment 6

[Jim Mathies [:jimm]]

Attachment: fix

Fixes a mistake I made in bug 896294.

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 783117 [details] [diff] [review]
fix

I should have caught that in review; sorry about that!

Comment 9

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ef8b0214e7e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ef8b0214e7e

Comment 11

[Ed Morley [:emorley]]

Please can bugs changing these parts of the tree land on fx-team in the future to help balance load & avoid conflicts (for more info see Gavin's newsgroup post: https://mail.mozilla.org/pipermail/firefox-dev/2013-July/000618.html). Thank you :-)

Comment 12

[Manuela Muntean [Away]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130819030205

WFM
Tested on Windows 8 32bit and 64bit using latest Nightly for iteration #12. Horizontal scroll bar isn't visible in Settings and About flyouts.