898541 - [Mac HiDPI]: "Thunderbird" text and icon in About window should be HiDPI

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Nomis101]

If you go to the TB About window, the text "Thunderbird" and the TB icon are blurry on a Mac with Retina display because there are not HiDPI

Comment 1

[Nomis101]

Attachment: Screenshot of the issue

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug898541.patch

This patch uses on official channel for the TB icon and the wordmark a SVG image to be DPI independent. For Daily only the wordmark is a SVG. This because the Daily icon looks also on HiDPI good. And the main reason: we don't have a SVG image for this icon.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8975276 [details] [diff] [review]
Bug898541.patch

Review of attachment 8975276 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/branding/thunderbird/content/about-logo.svg
@@ +1,3 @@
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

Just checking, is the logo indeed MPL licensed?

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Philipp Kewisch [:Fallen]  from comment #3)
> Comment on attachment 8975276 [details] [diff] [review]
> Bug898541.patch
> 
> Review of attachment 8975276 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/branding/thunderbird/content/about-logo.svg
> @@ +1,3 @@
> > +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> > +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> > +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> 
> Just checking, is the logo indeed MPL licensed?

I don't know. FX has the MPL license on the their wordmark, which is a SVG, too. I can remove the boilerplate when you think, it's better.

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

No, in that case it is fine, I'm assuming the TB wordmark is the same license then. Better to have a license in the file than no license at all.

Comment 6

[Richard Marti (:Paenglab)]

Thanks.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 8975276 [details] [diff] [review]
Bug898541.patch

branding/thunderbird is actually for TB 60. So it makes sense to uplift.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d6ce9744af9f
Make the about dialog HiDPI safe. r=philipp

Comment 9

[Jorg K (CEST = GMT+2)]

TB 60 beta 7 (BETA_60_CONTINUATION branch):
https://hg.mozilla.org/releases/comm-beta/rev/a3e607eab491

Comment 10

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr60/rev/9d4c95d173cc