898639 - [B2G][EVERYTHING.ME] [Unagi] User is unable to add apps to Homescreen from everything.me

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Shilpa Suresh]

Description:
User is unable to add facebook app to Homescreen through the star button in the bottom of the screen for facebook and twitter apps from everyhting.me

Repro Steps:
1) Updated Unagi to Build ID: 20130726030202
2) Navigate to Everything.me
3) Under Social category, Tap on Facebook/twitter app 
4) Enter the login information and sign into the account
5) Tap on the up arrow and select Star button at the bottom of the screen
6) Select Facebook/Twitter app to add to homescreen 
7) Navigate to Homescreen, observe that facebook/twitter apps are not added to homescreen

Actual:
Facebook/twitter apps cannot be added to Homescreen from everyhting.me

Expected:
Facebook/twitter apps can be added to Homescreen from everyhting.me

Environmental Variables
Build ID: 20130726030202
Gecko: http://hg.mozilla.org/mozilla-central/rev/46d73e889cb4
Gaia: a3d7268219f6ff92d296a3305bdfef14209885dc
Platform Version: 25.0a1

Notes:
Repro frequency: 100%
See attached: screenshot,logcat

Comment 1

[Shilpa Suresh]

Attachment: LogCat

Comment 2

[Jason Smith [:jsmith]]

Ran Ben Aharon - Can you look into this? This is breaking daily smoke tests on 1.2 right now.

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

We're investigating it.
A few of our findings - happens for all apps. Not only facebook and twitter. Happens in the Gaia browser as well.

Will fill you in soon when we have more info.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Ran Ben Aharon (Everything.me) from comment #3)
> We're investigating it.
> A few of our findings - happens for all apps. Not only facebook and twitter.
> Happens in the Gaia browser as well.

So this happens when adding bookmarks to the homescreen then, right?

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

That's right. But it all works fine unless Evme is loaded :/

Comment 6

[Amir Nissim (:amirn)]

Attachment: Patch - redirect to github PR

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 786412 [details]
Patch - redirect to github PR

use strict! This patch is just a very small patch to add some missing |var|.

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

I'm not sure it's crucial for leo Vivien. It seems to work fine without it.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Ran Ben Aharon (Everything.me) from comment #9)
> I'm not sure it's crucial for leo Vivien. It seems to work fine without it.

Right. I thought this only impacted 1.2?

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Oups! koi? would be fine by me.

Comment 12

[Jason Smith [:jsmith]]

Ran - Is this ready to land?

Comment 13

[Ran Ben Aharon [:ranbena] EverythingMe]

Working on landing it on master

Comment 14

[Ran Ben Aharon [:ranbena] EverythingMe]

Tested and landed in master 91b529657a01a4e3e8781dc28533ed192320c210

Comment 15

[Jason Smith [:jsmith]]

Closing per landing in https://github.com/mozilla-b2g/gaia/commit/91b529657a01a4e3e8781dc28533ed192320c210.

Comment 16

[Shilpa Suresh]

This issue no longer occurs on Buri v1.2. Verifying as Works for me.
User is able to add apps to Home screen from everything.me(Homescreen)

Environmental Variables
Build ID: 20130904040205
Gecko: http://hg.mozilla.org/mozilla-central/rev/7ff96bd19c1c
Gaia: b6c5bf1d24230bfed4a8f680e625fa2175001f82
Platform Version: 26.0a1
RIL Version: 01.01.00.019.206

Comment 17

[Jason Smith [:jsmith]]

This should be fixed per the landing, not works for me.