898766 - Plugincheck: search query for unknown plugin should be localizable

Status: RESOLVED FIXED

(Websites :: plugins.mozilla.org, defect)

Description

[Francesco Lodolo [:flod]]

Problem was originally reported in bug 892470 comment 19. 

When clicking on the "Research" blue button for an unknown plugin, users are taken to google with a search query that is always in English ("current version plugin X").

The search query string should be localizable, as it was in the previous version of plugincheck.

Comment 1

[Pascal Chevrel:pascalc]

I grepped our whole repo for 'current version plugin' and we don't have that string in English, the string seems to be hardcoded in the minified js file that is actually outside of our site on the cdn :
https://mozorg.cdn.mozilla.net/media/css/plugincheck-min.css?build=6279ac9

Comment 2

[Pascal Chevrel:pascalc]

sorry, at this url:
https://mozorg.cdn.mozilla.net/media/js/plugincheck-min.js?build=6279ac9

Comment 3

[Pascal Chevrel:pascalc]

Apparently, the other js-generatef strings are using this template:
https://github.com/mozilla/bedrock/blob/master/media/js/plugincheck/tmpl/plugincheck.ui.tmpl.js

Comment 4

[AYMAN]

No solution!!

Comment 5

[Kohei Yoshino [:kohei]]

How about removing the extra "current version plugin" label so we won't have to localize it.

Comment 6

[Schalk Neethling [:espressive]]

(In reply to Kohei Yoshino [:kohei] from comment #5)
> How about removing the extra "current version plugin" label so we won't have
> to localize it.

This will fix things quickly but, I believe the extra bit is added just to make it easier for users. Just searching for the plugin will not always take you to the latest version. I believe we can fix this.

Comment 7

[Schalk Neethling [:espressive]]

Pull request sent: https://github.com/mozilla/bedrock/pull/1139

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d6422505416bc2d46747b998f30ff2af0628d2c5
Fix Bug 898766, use window trans to ensure search query is localizable

https://github.com/mozilla/bedrock/commit/6332fcb4f36cb6a6b99dd94212daf20e01a02d53
Merge pull request #1139 from ossreleasefeed/bug898766-search-query-should-be-localizable

Fix Bug 898766, use window trans to ensure search query is localizable

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/9cf0e7625e601479b6f89fabcb0fe54b349c9d5f
[bug 898766] plugin search query should use https

https://github.com/mozilla/bedrock/commit/eebdc2387a44c5866f65557d3befe794a4b3367f
Merge pull request #1150 from alexgibson/bug-898766-search-query-should-use-https

[bug 898766] plugin search query should use https

Comment 10

[Francesco Lodolo [:flod]]

As a reference, string was added in all locales in r118936.