899233 - Text input is screwy in textarea

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(not currently active) Ted Mielczarek]

Using the testcase in the URL, performing the following steps (see attached video):
1) Type "abcd abcd"
2) Tap in the middle of the typed text to place the cursor there
3) Type "xyz"

Expected results:
Textbox contains "abcd xyzabcd"

Actual results:
Textbox contains "abcd xyz", the typed text overwrote the original text.


This is with the 2013-07-28 Nightly on a Nexus 4 running Android 4.2.2, default Google Keyboard.

I've been seeing some other odd behavior as well but I can't reproduce it as readily, like I tapped in the middle of some text, typed something, then tried to tap at the end to type more there, but the cursor snaps back to the middle of the text when I start typing again.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Video of bug reproduction

Oops, forgot to attach the video.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Notify InputMethodManager of selection when not in extracted mode (v1)

Turns out Android expects us to always tell it about selection changes, except when in extracted mode.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't restart IME when changing selection (v1)

When changing selection by tapping, we don't actually need to restart the IME; we just have to show it. We also preserve the IME's states by not restarting it.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 789786 [details] [diff] [review]
Notify InputMethodManager of selection when not in extracted mode (v1)

Review of attachment 789786 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! You might consider adding a comment explaining why extracted text mode is a special case.

Comment 5

[Chris Peterson [:cpeterson]]

Comment on attachment 789789 [details] [diff] [review]
Don't restart IME when changing selection (v1)

Review of attachment 789789 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: widget/android/AndroidBridge.h
@@ +126,5 @@
>      enum {
>          // Values for NotifyIME, in addition to values from the Gecko
>          // NotificationToIME enum; use negative values here to prevent conflict
>          NOTIFY_IME_REPLY_EVENT = -1,
> +        NOTIFY_IME_OPEN_VKB = -2,

Please order these enum names by value so AndroidBridge use the same order as GeckoEditableListener.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0760ef9e0bc
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac3f07dc2ff3

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f0760ef9e0bc
https://hg.mozilla.org/mozilla-central/rev/ac3f07dc2ff3