899326 - Recurrences with BYMONTHDAY=X,X,31 don't show at all in months with less than 31 days

Status: RESOLVED FIXED

(Calendar :: ICAL.js Integration, defect)

Description

[Markus Adrario [:Taraman]]

User Agent 	Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Thunderbird/25.0a1
Lightning	2.7a1

BYMONTHDAY Rule parts which are bigger than the days in month should simplý be skipped.
Here, the Whole month gets skipped.

Reproducible: Always

Steps to Reproduce:
1. create a recurring item with some days including the 31st
2. navigate to a month with less than 31 days.

result:
In this month none of the occurrences are shown.

expected result:
The occurrences earlier in the month should be shown.

Comment 1

[Markus Adrario [:Taraman]]

Attachment: Patch V1

This is caused by automatic normalization of the "last" date if this.last.date gets set > daysInMonth.
In this case, the normalization function will increment the month.

Comment 2

[Markus Adrario [:Taraman]]

Attachment: Patch V1.1

Forgot to include one line in this patch ISO another one.

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 785426 [details] [diff] [review]
Patch V1.1

Can you please add/update the tests to add a case for this?

Comment 4

[Markus Adrario [:Taraman]]

Attachment: Patch V2

I added a test to test_recur.js.

to make the tests run on icaljs, the pref needs to be set and two tests have to be disabled, since they fail.
To make this easier, I wrote a small patch [1] which can be found in my mq-patch repo 


[1]: http://hg.mozilla.org/users/Mozilla_Adrario.de/mq-patches/file/efbad47506ee/enable-icaljs-testing.diff

Comment 5

[Markus Adrario [:Taraman]]

This bug is fixed upstream in ical.js.

The tests will go into calendar with Bug 908745

Comment 6

[Martin Schröder [:mschroeder]]

Comment on attachment 789816 [details] [diff] [review]
Patch V2

Landed upstream, removing review request.

Comment 7

[Stefan Sitter [:ssitter]]

Should be fixed by Bug 932217 in Lightning 3.2.