899380 - apostrophes added in Inspector are changed to '

Status: RESOLVED DUPLICATE of bug 899375

(DevTools :: Inspector, defect)

Description

[Mark Bokil]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130725195523

Steps to reproduce:

In Inpsector attempt to add an apostrophe to a line such as onclick="javascript:sort('a');"


Actual results:

apostrophe is changed to '


Expected results:

should stay as an apostrophe character

Comment 1

[Brian Grinstead [:bgrins]]

Paul/Mike: Is there a reason why ' is being replaced with ' in the markup view?  https://github.com/mozilla/mozilla-central/blob/fx-team/browser/devtools/markupview/markup-view.js#L1471.  Removing it resolves this issue.

Comment 2

[Brian Grinstead [:bgrins]]

Mark,
Thanks for reporting this!

I talked with dcamp about this issue, and we should be fine with not escaping the ' character inside of attributes.  Patch is incoming.

Comment 3

[Mark Bokil]

Sure, no problem. I noticed it debugging a site and it kept switching characters on me. I figured it would affect others. Are you also working on the Network tab? I used it the other day to debug a large intranet. Very handy tool. We could see the response code was wrong coming from our web cache app and the Network tool made it easy to find. I would love to be able to collapse all columns to the left of Header so I can see the Response 100% width. Is that planned?

Comment 4

[Brian Grinstead [:bgrins]]

>Are you also working on the Network tab?

Mark, 
This is for a different component, so I went ahead and opened a new bug for it: https://bugzilla.mozilla.org/show_bug.cgi?id=899727.  You can add yourself to the CC list for that bug to get updates, and feel free to leave a comment there with any more information.

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: 899380.patch

Prevents converting ' into '

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 784400 [details] [diff] [review]
899380.patch

Review of attachment 784400 [details] [diff] [review]:
-----------------------------------------------------------------

Looks simple but we always need to ensure that all tests still run properly.

e.g. Test browser/devtools/markupview/test/browser_inspector_markup_edit.js would fail with this patch.

Can you fix the test and I will review it again?

Comment 7

[Brian Grinstead [:bgrins]]

Attachment: bug-899380-1.patch

Fixes browser_inspector_markup_edit.js test with new expected ' behavior.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Are you able to run this through try yourself?

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #8)
> Are you able to run this through try yourself?

No, waiting for approval on this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=900170

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I will do it then:
https://tbpl.mozilla.org/?tree=Try&rev=f44b6a0fdba4

Comment 11

[Brian Grinstead [:bgrins]]

This will be resolved by Bug 899375.