Paul/Mike: Is there a reason why ' is being replaced with ' in the markup view? https://github.com/mozilla/mozilla-central/blob/fx-team/browser/devtools/markupview/markup-view.js#L1471. Removing it resolves this issue.
Mark, Thanks for reporting this! I talked with dcamp about this issue, and we should be fine with not escaping the ' character inside of attributes. Patch is incoming.
Sure, no problem. I noticed it debugging a site and it kept switching characters on me. I figured it would affect others. Are you also working on the Network tab? I used it the other day to debug a large intranet. Very handy tool. We could see the response code was wrong coming from our web cache app and the Network tool made it easy to find. I would love to be able to collapse all columns to the left of Header so I can see the Response 100% width. Is that planned?
>Are you also working on the Network tab? Mark, This is for a different component, so I went ahead and opened a new bug for it: https://bugzilla.mozilla.org/show_bug.cgi?id=899727. You can add yourself to the CC list for that bug to get updates, and feel free to leave a comment there with any more information.
Created attachment 784400 [details] [diff] [review] 899380.patch Prevents converting ' into '
Comment on attachment 784400 [details] [diff] [review] 899380.patch Review of attachment 784400 [details] [diff] [review]: ----------------------------------------------------------------- Looks simple but we always need to ensure that all tests still run properly. e.g. Test browser/devtools/markupview/test/browser_inspector_markup_edit.js would fail with this patch. Can you fix the test and I will review it again?
Created attachment 784433 [details] [diff] [review] bug-899380-1.patch Fixes browser_inspector_markup_edit.js test with new expected ' behavior.
Are you able to run this through try yourself?
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #8) > Are you able to run this through try yourself? No, waiting for approval on this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=900170
I will do it then: https://tbpl.mozilla.org/?tree=Try&rev=f44b6a0fdba4
Attachment #784433 - Flags: review?(mratcliffe) → review+
This will be resolved by Bug 899375.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 899375
You need to log in before you can comment on or make changes to this bug.