899727 - Increase maximum size of response panel in network panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Brian Grinstead [:bgrins]]

Attachment: networkpanel-response.png

From: https://bugzilla.mozilla.org/show_bug.cgi?id=899380#c3

> Are you also working on the Network tab? I used it the other day to debug a large intranet. Very handy tool. We could see the response code was wrong coming from our web cache app and the Network tool made it easy to find. I would love to be able to collapse all columns to the left of Header so I can see the Response 100% width. Is that planned?

There was a request to be able to increase the size of the response panel more than is currently allowed.  Right now it appears to have a maximum size of around 40% of the panel

Comment 1

[Mark Bokil]

Attachment: possible expanded with option

Comment 2

[Mark Bokil]

Thanks for submitting the bug. I am tacking on an image of what it would it could look like expanded. Possibly a context option on File column for "View File Source" opening in regular source window would be helpful. Expanding the Response column so I can read the entire line would be great for usability.

Comment 4

[Samuel Hodge]

This is an absolute must. It's extremely difficult to debug XHR requests on my laptop because the maximum width is so small.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v1 (without whitespace changes)

This bug is a bit more involved, since resizing the sidebar will overflow over the footer with the filter buttons and the status text, so I moved to footer underneath everything. However, this leaves the XUL file poorly formatted; for an easier review, I'll attach a patch without whitespace changes for review.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1 (with whitespace changes) [landed]

This is what I'm going to land.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8373631 [details] [diff] [review]
v1 (without whitespace changes)

Review of attachment 8373631 [details] [diff] [review]:
-----------------------------------------------------------------

very well.

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/919cb665d715

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/919cb665d715

Comment 11

[Dane MacMillan [:danemacmillan]]

After resizing the panel to full available width, my cursor is unable to latch onto the edge of the panel to resize it again. It latches onto the browser window itself and resizes the browser. I restarted the browser but clicking onto a network asset loads the right panel in full width again. It's stuck, with seemingly no way to get it unstuck. This is on OSX Mavericks.

Here's an image of the area I'm trying to latch my cursor onto:

http://i.imgur.com/p2tSjp7.png


Also, see bug 971959. The panel icon used to open and close the panel has a higher z-index than the panel itself, so it does not disappear under the right panel when made wide enough. It's also not clickable, if the purpose was to make it appear as such.

Comment 12

[Dane MacMillan [:danemacmillan]]

Directly after posting this, I discovered another related bug. After having fully expanded the width of the right panel, there seems to be a hidden tab all the way to the right that loads the actual content of the page, unstyled. See the image: 

http://i.imgur.com/SgNoJab.png

Comment 13

[Dane MacMillan [:danemacmillan]]

(facepalm)

Ignore that last comment. It's actually the page Preview tab. I just hadn't resized the browser window wide enough to display the text. Perhaps the tabs should resize to make sure all text is visible?

Comment 11 is still valid.