899420 - Re-enable media mochitests

Status: REOPENED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The following mochitests were recently disabled:

test_seek
test_buffered
test_bug493187
test_playback_rate
test_bug465498
test_played
test_bug724904

We must re-enable these tests. The first three in this list in particular are the ones that fail for me locally when I stuff up, so we simply can't afford to risk going forward without these tests re-enabled.

It seems to me that most of the failures were actually happening in the new GStreamer backend on Linux, and to a lesser extent in the WMF backend. We're not shipping with the GStreamer backend enabled, so we can re-enable the tests except on Linux (and maybe Windows, we'll need to count the failures first). 

The Windows failures are mostly caused by bug 882537, which will be fixed when I integrate a new MP4 demuxer into our pipeline, but that will take a while.

Another option is to re-enable these tests, but change the tests to skip MPEG files on Windows and Linux.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Now that bug 912854 is fixed, we should be able to re-enable these tests on Linux now, right Edwin? They should only need to be disabled on Windows now.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Should be. I'll do a try run to verify.

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: enable-media-tests.patch

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a6c1e976e78

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4a6c1e976e78
https://hg.mozilla.org/mozilla-central/rev/03535a095116
https://hg.mozilla.org/mozilla-central/rev/5546db13122e
https://hg.mozilla.org/mozilla-central/rev/647c88c759c5
https://hg.mozilla.org/mozilla-central/rev/9fd3e98cf2f8
https://hg.mozilla.org/mozilla-central/rev/ad386a1ca2d2

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e50c18dc2122

Comment 7

[Jason Smith [:jsmith]]

Fixed as part of bug 916135.

Comment 8

[Jason Smith [:jsmith]]

Wait wrong bug, disregard.