899436 - OS.File stat.lastModificationDate returns lastAccessDate on Windows

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Found via bug 898598.  The give-away is the line in osfile_win_allthreads.jsm:

   this._lastModificationDate = lastAccessDate;

:)

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: osfile-last-modified-time.patch

The tests seem to pass with this change, but I'm not sure if anything else is necessary?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Ahaha, that would certainly be useful.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 782958 [details] [diff] [review]
osfile-last-modified-time.patch

Review of attachment 782958 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/5e5bb1036572

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5e5bb1036572

Comment 6

[Dan Stillman]

Any chance of landing this in Firefox 24 for the ESR? It looks pretty straightforward, and this bug is preventing us from using OS.File for various fairly impactful things involving hundreds or thousands of files in Zotero. At best, it will require us to maintain two versions of code (asynchronous and synchronous) for another year, and Zotero users on the ESR will have significantly worse performance.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Looks pretty straightforward, I don't see any reason not to uplift. Mark, want to request approvals?

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 782958 [details] [diff] [review]
osfile-last-modified-time.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Unknown
User impact if declined: Addon authors are unable to OS.File in some contexts.
Testing completed (on m-c, etc.): Landed on M-C on July 31.
Risk to taking this patch (and alternatives if risky): Low risk, limited to OS.File functionality on Windows.
String or IDL/UUID changes made by this patch: None

Please see comment 6 and comment 7

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Sorry for the spam, it seems I mis-clicked on the flags

Comment 10

[(PTO June 19-July 7) Ryan VanderMeulen]

This landed on m-c for Fx25, so this doesn't need uplifting to Aurora.

https://hg.mozilla.org/releases/mozilla-beta/rev/6c752934f8b5

Comment 11

[u279076]

Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.