Closed
Bug 899630
Opened 12 years ago
Closed 12 years ago
Intermittent Jetpack tests/test-tabs.testTabsEvent_onCloseWindow | Correct number of close events received (1 != 4) | Each tab with an attached onClose listener received a close event when the window was closed (0 != 3)
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(firefox24 unaffected, firefox25 fixed, firefox26 fixed)
RESOLVED
FIXED
mozilla26
Tracking | Status | |
---|---|---|
firefox24 | --- | unaffected |
firefox25 | --- | fixed |
firefox26 | --- | fixed |
People
(Reporter: RyanVM, Assigned: evold)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
https://tbpl.mozilla.org/php/getParsedLog.php?id=25906092&tree=Mozilla-Inbound
Ubuntu VM 12.04 mozilla-inbound debug test jetpack on 2013-07-30 04:22:30 PDT for push 80e1116e4599
slave: tst-linux32-ec2-102
TEST-START | tests/test-tabs.testTabsEvent_onCloseWindow
++DOCSHELL 0x11655e50 == 59 [id = 118]
++DOMWINDOW == 148 (0xead4d98) [serial = 274] [outer = (nil)]
++DOMWINDOW == 149 (0x111d8dd8) [serial = 275] [outer = 0xead4d98]
++DOCSHELL 0x1057a1b0 == 60 [id = 119]
++DOMWINDOW == 150 (0x1182a800) [serial = 276] [outer = (nil)]
++DOCSHELL 0x10e6d9a0 == 61 [id = 120]
++DOMWINDOW == 151 (0xecd4278) [serial = 277] [outer = (nil)]
++DOCSHELL 0x105a1950 == 62 [id = 121]
++DOMWINDOW == 152 (0xc06b860) [serial = 278] [outer = (nil)]
++DOMWINDOW == 153 (0x11e86780) [serial = 279] [outer = 0xc06b860]
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv) && subjPrincipal) failed: file ../../../docshell/base/nsDocShell.cpp, line 8392
WARNING: OpenGL-accelerated layers are not supported on this system: file ../../../widget/xpwidgets/nsBaseWidget.cpp, line 893
WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2374
++DOMWINDOW == 154 (0x12361250) [serial = 280] [outer = 0x1182a800]
WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2374
++DOMWINDOW == 155 (0x102ca5c0) [serial = 281] [outer = 0xecd4278]
++DOMWINDOW == 156 (0x102c9600) [serial = 282] [outer = 0xc06b860]
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
++DOCSHELL 0xcc24f00 == 63 [id = 122]
++DOMWINDOW == 157 (0x126b8148) [serial = 283] [outer = (nil)]
++DOMWINDOW == 158 (0xc0ced08) [serial = 284] [outer = 0x126b8148]
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
++DOCSHELL 0x12b69f28 == 64 [id = 123]
++DOMWINDOW == 159 (0x12ba6060) [serial = 285] [outer = (nil)]
++DOMWINDOW == 160 (0x10f126c0) [serial = 286] [outer = 0x12ba6060]
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
++DOCSHELL 0xf824700 == 65 [id = 124]
++DOMWINDOW == 161 (0x9323798) [serial = 287] [outer = (nil)]
++DOMWINDOW == 162 (0x109171c0) [serial = 288] [outer = 0x9323798]
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
TEST-UNEXPECTED-FAIL | tests/test-tabs.testTabsEvent_onCloseWindow | Correct number of close events received (1 != 4)
TEST-INFO | Traceback (most recent call last):
File "resource://extensions.modules.1ecb9965-c68e-4f88-9072-cfaab5cb3529-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 1051, in unload
callback();
File "resource://extensions.modules.1ecb9965-c68e-4f88-9072-cfaab5cb3529-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 522, in testFinished
test.assertEqual(closeCount, 4, "Correct number of close events received");
File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 189, in assertEqual
this.fail(message);
File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail
this.console.testMessage(false, false, this.test.name, message);
File "resource://gre/modules/commonjs/sdk/test/harness.js", line 525, in testMessage
this.trace();
TEST-UNEXPECTED-FAIL | tests/test-tabs.testTabsEvent_onCloseWindow | Each tab with an attached onClose listener received a close event when the window was closed (0 != 3)
TEST-INFO | Traceback (most recent call last):
File "resource://extensions.modules.1ecb9965-c68e-4f88-9072-cfaab5cb3529-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 1051, in unload
callback();
File "resource://extensions.modules.1ecb9965-c68e-4f88-9072-cfaab5cb3529-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 524, in testFinished
"Each tab with an attached onClose listener received a close " +
File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 189, in assertEqual
this.fail(message);
File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail
this.console.testMessage(false, false, this.test.name, message);
File "resource://gre/modules/commonjs/sdk/test/harness.js", line 525, in testMessage
this.trace();
WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 266
TEST-END | tests/test-tabs.testTabsEvent_onCloseWindow
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee: nobody → rFobic
Priority: -- → P1
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 14•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #790029 -
Flags: review?(zer0)
Assignee | ||
Updated•12 years ago
|
Attachment #790029 -
Flags: review?(zer0) → review?(dtownsend+bugmail)
Updated•12 years ago
|
Attachment #790029 -
Flags: review?(dtownsend+bugmail) → review+
Comment 15•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/b2af464e8f6d1893ca5ff8b32cdacc75638856f5
Bug 899630 - Intermittent Jetpack tests/test-tabs.testTabsEvent_onCloseWindow
* Using a safer method to close windows
https://github.com/mozilla/addon-sdk/commit/4ee16e49c0707a3f96c0baee14d030e3d76ce820
Merge pull request #1170 from erikvold/899630
Bug 899630 - Intermittent Jetpack tests/test-tabs.testTabsEvent_onCloseWindow. r=Mossop
Comment 16•12 years ago
|
||
Comment on attachment 790029 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1170
Reverted this because it made the tests fail
Attachment #790029 -
Flags: review+ → review-
Assignee | ||
Updated•12 years ago
|
Assignee: rFobic → evold
Assignee | ||
Comment 17•12 years ago
|
||
Comment on attachment 790029 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1170
The pull has been updated.
Attachment #790029 -
Flags: review- → review?(dtownsend+bugmail)
Assignee | ||
Comment 18•12 years ago
|
||
Comment on attachment 790029 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1170
bah I can't repoen the pull, I'll have to make a new one.
Attachment #790029 -
Flags: review?(dtownsend+bugmail)
Assignee | ||
Comment 19•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #790632 -
Flags: review?(dtownsend+bugmail)
Updated•12 years ago
|
Attachment #790632 -
Flags: review?(dtownsend+bugmail) → review+
Comment 20•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/d4a1a105eb59575773147d7487b9352d7e9ee126
Bug 899630 - Intermittent Jetpack tests/test-tabs.testTabsEvent_onCloseWindow
Removing the use of a special window closer to trigger end of test
https://github.com/mozilla/addon-sdk/commit/2892025b731a56b8ed5ed37d357a92c0b8cebc11
Merge pull request #1174 from erikvold/899630v2
Bug 899630 - Intermittent Jetpack tests/test-tabs.testTabsEvent_onCloseWindow r=@ZER0
Comment 21•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2eedd4dc1274
Not seen this in three days as it is so maybe this was fixed by something else already?
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•12 years ago
|
status-firefox24:
--- → unaffected
status-firefox25:
--- → affected
status-firefox26:
--- → fixed
Target Milestone: --- → mozilla26
Comment 22•12 years ago
|
||
Reporter | ||
Comment 23•12 years ago
|
||
Calling this fixed on Aurora by bug 907522.
You need to log in
before you can comment on or make changes to this bug.
Description
•