If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Uplift Add-on SDK code to mozilla-aurora to fix frequent intermittent test failures

RESOLVED FIXED in Firefox 25

Status

Add-on SDK
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: KWierso, Assigned: mossop)

Tracking

unspecified
mozilla25

Firefox Tracking Flags

(firefox24 wontfix, firefox25 fixed, firefox26 unaffected)

Details

(Reporter)

Description

4 years ago
We should uplift the recent fixes for the SDK's intermittent test failures to Aurora and Beta to clean up our tests before they hit the ESR branch or get disabled for being too noisy.
(Reporter)

Comment 1

4 years ago
One option would be to just take our git repository's firefox26 branch and merge it down to firefox25 and uplift all of that to Aurora (so Aurora and current-Central have identical code), and just cherry-pick individual test fixes/disables to firefox24 and uplift that to Beta.

This should significantly green up Aurora and Beta, while not doing too many risky changes on Beta. We still have a few months to catch any fallout before Firefox 25 releases in mid-October.

Jeff, Dave, Irakli: What do you think?
Flags: needinfo?(rFobic)
Flags: needinfo?(jgriffiths)
Flags: needinfo?(dtownsend+bugmail)
(Reporter)

Comment 2

4 years ago
(In reply to Wes Kocher (:KWierso) from comment #1)
> One option would be to just take our git repository's firefox26 branch*

* once we're reasonably sure we are no longer breaking things from bug 906682
FWIW, Jetpack is actually reasonably green on beta (Fx24), so cherry-picking some fixes to harden things seems like a good way to go IMO.

Comment 4

4 years ago
Thank you for filing this Wes! :-)
(Assignee)

Comment 5

4 years ago
The changelog for firefox25..firefox26 is https://github.com/mozilla/addon-sdk/compare/firefox25...firefox26

It's large because all of the UX work is in there, but it shouldn't be active since australis isn't there. There are a few changes to match m-c changes, like indexeddb fixes, a good first step would be to make sure that landing all that stuff on aurora actually passes tests.

I'm not entirely opposed but a little wary of landing so much without having been through all those changesets with a fine toothcomb yet.
Flags: needinfo?(dtownsend+bugmail)
(Assignee)

Comment 6

4 years ago
Started a try run: https://tbpl.mozilla.org/?tree=Try&rev=f998c39331c5
(Assignee)

Comment 7

4 years ago
Looks like at the very least the devtools console changes are breaking us.

I think since we have to cherry-pick fixes for beta we might as well just land those same fixes on aurora too rather than going for the fuller uplift. I'll look at which fixes to take tomorrow.
(Assignee)

Comment 8

4 years ago
This is what I'll propose for aurora once the try runs are in: https://github.com/Mossop/addon-sdk/compare/firefox25. Assuming that all passes I'll check that the same changes apply to beta.
Assignee: nobody → dtownsend+bugmail
Flags: needinfo?(rFobic)
Flags: needinfo?(jgriffiths)
(Assignee)

Comment 9

4 years ago
In terms of beta uplift, I've attempted to cherry-pick those same changesets and it is so different that it becomes painful fast. So instead I looked to see what tests are particularly harming the beta branch to maybe only cherry-pick fixed for those. But the beta branch looks entirely green and brasstacks claims that there are no real test failures there. Am I missing something?
Nope, see comment 3 :). If there aren't any easy cherry picks for beta, I'm OK with leaving things as-is for now. If at some point we do find some test to be problematic, we can always address it then.
(Assignee)

Comment 11

4 years ago
Ok let's just stick with aurora for now
Summary: Uplift Add-on SDK code to mozilla-aurora and mozilla-beta to fix frequent intermittent test failures before they hit the ESR. → Uplift Add-on SDK code to mozilla-aurora to fix frequent intermittent test failures before they hit the ESR.
(Assignee)

Comment 12

4 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/2e36e2efcfe2
status-firefox24: --- → wontfix
status-firefox25: --- → fixed
status-firefox26: --- → unaffected
Summary: Uplift Add-on SDK code to mozilla-aurora to fix frequent intermittent test failures before they hit the ESR. → Uplift Add-on SDK code to mozilla-aurora to fix frequent intermittent test failures
Target Milestone: --- → mozilla25
(Assignee)

Comment 13

4 years ago
I think we're done here
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.