899666 - [AccessFu] Support text selection in Jellybean

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Comment 1

[Max Li [:maxli]]

Attachment: Patch

So this patch seems to work when not using the standard Google keyboard, but due to bug 899633 (and possibly bug 892945) when using that keyboard it doesn't work properly with that keyboard.

Comment 2

[Max Li [:maxli]]

So this is probably dependent on android issue 54205 (http://code.google.com/p/android/issues/detail?id=54205).

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 786964 [details] [diff] [review]
Patch

Review of attachment 786964 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAccessibility.java
@@ +323,5 @@
> +                                if (Build.VERSION.SDK_INT >= 18) {
> +                                    try {
> +                                        info.addAction(AccessibilityNodeInfo.class.getField("ACTION_SET_SELECTION").getInt(AccessibilityNodeInfo.class));
> +                                        if (((Boolean) AccessibilityNodeInfo.class.getMethod("isEditable").invoke(info)).booleanValue()) {
> +                                            info.setClassName("android.widget.EditText");

This seems really scary to me. I wonder if we should wait for Google to get the kinks out of their system. Or even contribute a patch to TalkBack..