899810 - APZC broken in Metro after landing bug 866232

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Brian R. Bondy [:bbondy]]

After bug 866232 landed we have:
- When zooming the screen will eventually either completely turn white or black - Pinch to zoom doesn't zoom into the correct focal point

Comment 1

[Brian R. Bondy [:bbondy]]

Hey Kats, any suggestions on how to fix? 

See Comment 0, also when it goes into the all white or all black state you can't unpinch to get back to zoom level 1.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Not off the top of my head, no. This sounds pretty broken and I don't know why it's happening. I'll have to figure out some way to build metro and reproduce this to debug it.

Comment 3

[Brian R. Bondy [:bbondy]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Not off the top of my head, no. This sounds pretty broken and I don't know
> why it's happening. I'll have to figure out some way to build metro and
> reproduce this to debug it.

I'd recommend getting a win8 device if possible I'm not sure if a VM w/ win8 will work well enough. Maybe a surface pro w/ type keyboard since it's high dpi as well.
CC'ing marco in case he can expedite the process.

Comment 4

[Brian R. Bondy [:bbondy]]

Marco kats is in the TO office if it helps.

Comment 5

[Marco Mucci [:MarcoM]]

Hey Kats, I have a spare win8 device.  Are you in the office on Thursday?  If so, let me know what time and I'll meet you there.  Thanks.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I filed a service now request (REQ0017691) for one. But until that shows up if I can borrow yours that would be great, thanks. I'll be in the office tomorrow from around 10am onwards.

Comment 7

[Marco Mucci [:MarcoM]]

No problem.  I'll find you at the office tomorrow shortly after 10.  Thanks.

Comment 8

[Brian R. Bondy [:bbondy]]

Short update here: Marco met up with kats yesterday and gave a device, kats was installing Visual Studio and doing the rest of the dependency tasks to get a metro build going.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Fix black screen issue

This should fix the black screen issue. I still need to investigate the focal point problem, will have a separate patch for that. Can you apply this patch and verify that it fixes the black screen problem for you as well?

Comment 10

[Brian R. Bondy [:bbondy]]

Comment on attachment 785334 [details] [diff] [review]
Fix black screen issue

Review of attachment 785334 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if I have the powers to review this, but the reasoning makes sense and I tested locally and it fixes the black screen issue.

Comment 11

[Brian R. Bondy [:bbondy]]

Thanks for the quick turnaround on this by the way :)

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Landed this patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/ec3a5e429ea2

I will track the focal point problem over in bug 901339.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec3a5e429ea2