899908 - Remove support for reloading the worker for a social provider.

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

We currently allow a worker to send us a message to force a reload of a worker, and we go to lengths to reconnect all ports etc so the reload is seamless from the POV of the provider's sidebar etc.  This was added explicitly at the request of Facebook to work around issues in their code.

The problem with this is that it's probably impossible (without dedicated support for this by the platform) to implement with real workers.  Shane and I agreed a good approach might be:

a) initially "whitelist" this feature so it is only available for use by Facebook, thus preventing other providers from relying on it.

b) change the implementation so that it completely reloads the entire provider (ie, reloading the sidebar etc too, as if the provider was starting for the first time).  This means no need to reconnect etc.

I guess if (b) was done quickly enough we needn't do (a).

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-899908-remove-ability-for-a-social-worker-to-rel.patch

With this patch, a social.reload-worker message reloads the entire provider.  There is no longer a "reload()" method on the worker.  This removes *alot* of relatively hairy code, which ya gotta love :)

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 801975 [details] [diff] [review]
0001-Bug-899908-remove-ability-for-a-social-worker-to-rel.patch

nice!  run a try?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

https://tbpl.mozilla.org/?tree=Try&rev=a409862e830a

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Old try looks like it was before a dependent bug actually landed.

New green try at https://tbpl.mozilla.org/?tree=Try&rev=f1aee90c7fe3

https://tbpl.mozilla.org/?tree=Try&rev=f1aee90c7fe3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/88a9034541fd