899973 - GC: Convert the rest of the JS property API to use MutableHandleValue for out params

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: property-api-mhv

Following on from bug 897484 and bug 896540, let's convert the rest of the JS property API to use MutableHandleValue for out parameters.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: property-api-mhv-browser

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 783707 [details] [diff] [review]
property-api-mhv

Review of attachment 783707 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +3144,2 @@
>  JS_PUBLIC_API(JSBool)
>  JS_LookupElement(JSContext *cx, JSObject *objArg, uint32_t index, jsval *vp)

How about this one?

@@ +3973,5 @@
>      JSBool succeeded;
>      if (!JSObject::deleteByValue(cx, obj, StringValue(atom), &succeeded))
>          return false;
>  
> +    rval.setBoolean(succeeded);

These really should become bool*s

Comment 3

[Jon Coppeard (:jonco)]

(In reply to :Ms2ger from comment #2)

> How about this one?

I'm leaving the JS_*Element() ones for the next bug.

> These really should become bool*s

Good idea - I'll do that as a followup bug too.

Comment 4

[Steve Fink [:sfink] [:s:]]

Comment on attachment 783707 [details] [diff] [review]
property-api-mhv

Review of attachment 783707 [details] [diff] [review]:
-----------------------------------------------------------------

Yay! It's really great to see these changing.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 783710 [details] [diff] [review]
property-api-mhv-browser

>+    JS::RootedValue prop(cx);

(Making rooting hazards not compile)++.

r=me

Comment 6

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e291816b49be
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ee8be4e4815

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e291816b49be
https://hg.mozilla.org/mozilla-central/rev/5ee8be4e4815

Comment 8

[Florian Scholz (Open Web Docs)]

Docs updated by :arai :)

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_Reference/JS_LookupProperty
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_LookupElement
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetOwnPropertyDescriptor
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_DeleteProperty2

Technical review appreciated.