Closed
Bug 899980
Opened 11 years ago
Closed 11 years ago
Work - NewUI - Show fox in urlbar if on start screen, search glass if searching
Categories
(Firefox for Metro Graveyard :: App Bar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: jimm, Assigned: rsilveira)
References
Details
(Whiteboard: [preview][shovel-ready])
Attachments
(2 files)
6.80 KB,
application/zip
|
Details | |
10.07 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
- back button is hidden
- in edit navbutton changes to 'X' clear state and clears contents/closes auotcomplete. (currently we display the navigate arrow button.)
- all navbar side button hide except a close X with a circle
- navbar favicon changes to a search magnifying glass
Updated•11 years ago
|
Whiteboard: [preview]
Updated•11 years ago
|
Whiteboard: [preview] → [preview][shovel-ready]
Comment 1•11 years ago
|
||
So, we implemented most of this in another bug, so morphing this to cover the last two remaining changes that we need to do listed in the description.
Summary: Update navbar button / image states when autocomplete is visible → Work - NewUI - Show fox in urlbar if on start screen, search glass if searching
Comment 2•11 years ago
|
||
Since you morphed the title where is this fox icon and search glass? Are they already in images/ ?
Flags: needinfo?(jwilde)
Comment 3•11 years ago
|
||
We need those from shorlander. Specifically, I'm referring to the icons in the last two items in this spec: http://people.mozilla.com/~shorlander/files/design-specs-metro/images-design-spec-sheets/Windows8-i03-DesignSpec-%28NavBar%29-i02.jpg
Flags: needinfo?(jwilde)
Comment 4•11 years ago
|
||
May we have the tiny fox and search glass icons? :)
Flags: needinfo?(shorlander)
Comment 5•11 years ago
|
||
Flags: needinfo?(shorlander)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Comment 7•11 years ago
|
||
Comment on attachment 813237 [details] [diff] [review]
899980.patch
Review of attachment 813237 [details] [diff] [review]:
-----------------------------------------------------------------
I was going to suggest adding <html:link rel="icon" href="..."/> to Start.xul instead, but I guess we don't have a good way of handling multiple sizes yet. :/
Attachment #813237 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Yeah, that would be handy...
https://hg.mozilla.org/integration/fx-team/rev/ea63f54d8c05
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•