Closed Bug 900044 Opened 6 years ago Closed 6 years ago

Get rid of viewport-needs-updating and related code

Categories

(Firefox for Metro Graveyard :: Pan and Zoom, defect)

25 Branch
x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: bbondy, Assigned: bbondy)

References

Details

Attachments

(2 files)

It would simply the code to just call setDisplayPortForElement instead of going back to widget to get the frame metrics values from apzc.
Should make it easier to find the source of the problem in bug 899810
Assignee: nobody → netzen
Attachment #783837 - Flags: review?(bugmail.mozilla)
Blocks: metro-apzc
No longer blocks: 869940
Comment on attachment 783837 [details] [diff] [review]
Simplify viewport-needs-updating code. rev1

Review of attachment 783837 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Note that you should be able to get rid of MetroCompositorParent entirely, and just move those two lines of code to wherever the compositor is created.

::: widget/windows/winrt/MetroWidget.cpp
@@ +810,2 @@
>  protected:
>    nsCOMPtr<MetroWidget> mMetroWidget;

You can also get rid mMetroWidget.
Attachment #783837 - Flags: review?(bugmail.mozilla) → review+
Attachment #783837 - Attachment description: Patch v1. → Simplify viewport-needs-updating code. rev1
Attachment #783878 - Flags: review?(bugmail.mozilla)
Attachment #783878 - Flags: review?(bugmail.mozilla) → review+
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.