Marionette errors in onPacket lack exception information

RESOLVED FIXED in Firefox 25

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

unspecified
mozilla25
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox23 wontfix, firefox24 wontfix, firefox25 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
When Marionette catches an exception in onPacket, we don't include any information about the original exception, e.g.,

09:07:09     INFO -  errors.MarionetteException: {u'message': {}, u'error': u"error occurred while processing 'deleteSession"}
Assignee

Updated

6 years ago
Assignee: nobody → jgriffin
Comment on attachment 783831 [details] [diff] [review]
Use e.message instead of e in onPacket errors,

lgtm
Attachment #783831 - Flags: review?(wlachance) → review+
https://hg.mozilla.org/mozilla-central/rev/83e77ea05fd2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee

Updated

6 years ago
Keywords: checkin-needed
Apparently I forgot to mark this bug when it landed on the v1.1hd branch. My apologies.
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/ba71c64705e5
You need to log in before you can comment on or make changes to this bug.