900246 - opt build warning: DirectionalityUtils.cpp:538:14: warning: unused variable 'clearedEntries' [-Wunused-variable]

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning, in Android opt builds:
{
content/base/src/DirectionalityUtils.cpp:538:14: error: unused variable 'clearedEntries' [-Werror=unused-variable]
}

Sample log (with an experimental FAIL_ON_WARNINGS in this directory, turning this into an error): https://tbpl.mozilla.org/php/getParsedLog.php?id=25991288&tree=Try

Looks like this variable wants to be DebugOnly.

Comment 1

[Daniel Holbert [:dholbert]]

(or, better, this whole function-body probably wants to be #ifdef DEBUG, since its only purpose appears to be getting a value to assert about.)

Comment 2

[Daniel Holbert [:dholbert]]

(ignore comment 1; I misremembered the line of code as just getting an array size rather than doing actual array-clearing)

DebugOnly it is.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: 900246-fix.patch

Comment 4

[Daniel Holbert [:dholbert]]

https://tbpl.mozilla.org/?tree=Try&rev=83ef149fb7b5

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d2419297ec8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6d2419297ec8