Closed Bug 900382 Opened 6 years ago Closed 5 years ago

Define new key names, "Standby", "PowerOff", "WakeUp", "LogOff", "Suspend" and "Hibernate" for Windows, GTK and Qt

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: masayuki, Assigned: masayuki)

References

()

Details

(Whiteboard: [u= c= p=0])

Attachments

(1 file)

Whiteboard: [u= c= p=0]
Status: NEW → ASSIGNED
D3E-key now defines, "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp".

They are defines as:
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-key.html#h3_keys-device
Attachment #8445176 - Flags: review?(romaxa)
Attachment #8445176 - Flags: review?(karlt)
Attachment #8445176 - Flags: review?(bugs)
Summary: Define new key names, "Standby", "PowerDown", "PowerOff", "WakeUp", "Sleep", "LogOff", "Suspend" and "Hibernate" for Windows, GTK and Qt → Define new key names, "Standby", "PowerOff", "WakeUp", "LogOff", "Suspend" and "Hibernate" for Windows, GTK and Qt
Comment on attachment 8445176 [details] [diff] [review]
Support "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp" key values on GTK and Qt

Oops, Windows has VK_SLEEP and it's mapped to "Sleep".
Attachment #8445176 - Flags: review?(jmathies)
Attachment #8445176 - Flags: review?(romaxa) → review+
Comment on attachment 8445176 [details] [diff] [review]
Support "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp" key values on GTK and Qt

XF86XK_PowerDown is labelled "Deep sleep the system" in the section "These are
sometimes found on PDA's (e.g. Palm, PocketPC or elsewhere)" and is not on any
keyboard in xkeyboard-config.  I think it would be best to remove it.
Including it may just increase confusion about this key.
Attachment #8445176 - Flags: review?(karlt) → review+
(In reply to Karl Tomlinson (needinfo?:karlt) from comment #3)
> XF86XK_PowerDown is labelled "Deep sleep the system" in the section "These are
> sometimes found on PDA's (e.g. Palm, PocketPC or elsewhere)" and is not on any
> keyboard in xkeyboard-config.

Yeah, "PowerDown" was also defined in old D3E draft. However, for smaller and simpler spec, it was merged with "PowerOff". Therefore, D3E's "PowerOff" value is now defines as:

'PowerOff'	The PowerOff key. Sometime called "PowerDown".
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-key.html#key-PowerOff

> I think it would be best to remove it.
> Including it may just increase confusion about this key.

Even with the above definition, do you think that we shouldn't map it with "PowerOff"?
Removing PowerDown from D3E was good.

I don't think XF86XK_PowerDown is used any longer, and so I don't think there is any need to add support for it, but, given D3E already references it, it's not a big problem to include it here, if you like.
Attachment #8445176 - Flags: review?(bugs) → review+
Attachment #8445176 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/40b3358b1d4b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.