900382 - Define new key names, "Standby", "PowerOff", "WakeUp", "LogOff", "Suspend" and "Hibernate" for Windows, GTK and Qt

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Power management related keys are defined.
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21118

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Support "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp" key values on GTK and Qt

D3E-key now defines, "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp".

They are defines as:
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-key.html#h3_keys-device

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8445176 [details] [diff] [review]
Support "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp" key values on GTK and Qt

Oops, Windows has VK_SLEEP and it's mapped to "Sleep".

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8445176 [details] [diff] [review]
Support "LogOff", "PowerOff", "Hibernate", "Standby" and "WakeUp" key values on GTK and Qt

XF86XK_PowerDown is labelled "Deep sleep the system" in the section "These are
sometimes found on PDA's (e.g. Palm, PocketPC or elsewhere)" and is not on any
keyboard in xkeyboard-config.  I think it would be best to remove it.
Including it may just increase confusion about this key.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Karl Tomlinson (needinfo?:karlt) from comment #3)
> XF86XK_PowerDown is labelled "Deep sleep the system" in the section "These are
> sometimes found on PDA's (e.g. Palm, PocketPC or elsewhere)" and is not on any
> keyboard in xkeyboard-config.

Yeah, "PowerDown" was also defined in old D3E draft. However, for smaller and simpler spec, it was merged with "PowerOff". Therefore, D3E's "PowerOff" value is now defines as:

'PowerOff'	The PowerOff key. Sometime called "PowerDown".
https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-key.html#key-PowerOff

> I think it would be best to remove it.
> Including it may just increase confusion about this key.

Even with the above definition, do you think that we shouldn't map it with "PowerOff"?

Comment 5

[Karl Tomlinson (:karlt)]

Removing PowerDown from D3E was good.

I don't think XF86XK_PowerDown is used any longer, and so I don't think there is any need to add support for it, but, given D3E already references it, it's not a big problem to include it here, if you like.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40b3358b1d4b

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/40b3358b1d4b